Closed Bug 23739 Opened 25 years ago Closed 25 years ago

[PP] [blocker]Color Picker onclick handler is not called when in XUL popup

Categories

(Core :: XUL, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: cmanske, Assigned: danm.moz)

References

Details

(Keywords: platform-parity, Whiteboard: [PDT-])

All examples of using the color picker in XUL are not working: Go to Preferences, Appearance, Colors and try the color pickers there. Or launch a Composer window and click on the color buttons in the toolbar. For the latter, you should see a message in the debug window when you click on a color in the color picker.
*** Bug 23740 has been marked as a duplicate of this bug. ***
Blocks: 21410
adding dependency from dup'd bug
Summary: [blocker]Color Picker onclick hanlder is not called → [blocker]Color Picker onclick handler is not called
the test color picker works. if all of the others are broken, something else has broken them.
Assignee: pavlov → cmanske
the prefs one works. there seems to be a bug in the compose one. reassigning
Nice try! The prefs color pickers do NOT work in my debug build or in the optimized build from 1/12. The colorpicker in the test file (Menu: Debug | XPWidgets | Colorpicker) that is on the page works, but the colorpickers inside <menupopup>s don't work. So we must not be calling the right JS context when in a <popup> or <menupopup>?
Assignee: cmanske → pavlov
Summary: [blocker]Color Picker onclick handler is not called → [blocker]Color Picker onclick handler is not called when in XUL popup
Assignee: pavlov → danm
Hardware: All → PC
Summary: [blocker]Color Picker onclick handler is not called when in XUL popup → [PP] [blocker]Color Picker onclick handler is not called when in XUL popup
They work fine on Linux. They don't work on Windows. Platform parity bug on windows. Probably some kind of modal stupidness. Reassigning to danm.
Target Milestone: M14
adding myself to Cc: list.
Keywords: pp
Blocks: 24854
*** Bug 24580 has been marked as a duplicate of this bug. ***
Putting on beta1 radar.
Keywords: beta1
Putting on PDT- radar for beta 1. We want color picker, but would not stop ship beta1. If you make it in great. But would not hold.
Whiteboard: [PDT-]
Keeping in mind that colour pickers seem to be largely not hooked up -- only the text foreground menu in Preferences/Appearance/Colors seems functional, and the colour popup in Composer won't even summon the colour popup today (I'm pretty sure it got at least that far yesterday), this is working now. At least the basic problem with the widget not accepting mouse events; the problem that this bug is all about, has been cleared up. It works in test pages and for prefs foreground text colour.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Bingo! I'm not sure what Dan's problem was, but the color picker is finally working on the Composer toolbar.
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.