Closed
Bug 24132
Opened 25 years ago
Closed 25 years ago
Crash using createPopup
Categories
(Core :: XUL, defect, P3)
Core
XUL
Tracking
()
RESOLVED
FIXED
M14
People
(Reporter: michael.j.lowe, Assigned: hyatt)
Details
(Keywords: crash, Whiteboard: Wating code review)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
If call from Javascript:
window.createPopup(document.getElementById('urlbar'),
document.getElementById('popup'), 0, 0, 'popup', 'topleft','topleft');
Mozilla crashes. I think the problem is that nsWebShellWindow::CreatePopup
is not returning the [nsIDOMWindow** outPopup] parameter.
Reporter | ||
Updated•25 years ago
|
Assignee: trudelle → hyatt
Reporter | ||
Comment 1•25 years ago
|
||
->hyatt
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M17
Assignee | ||
Comment 2•25 years ago
|
||
This function has not been updated to reflect the new popup code. Low
priority. Moving to M17.
Reporter | ||
Comment 3•25 years ago
|
||
Could I get a hint what needs to be done here? I'd like to have a go at
implementing URL autocomplete and this is a necessary function for this I think.
Assignee | ||
Comment 4•25 years ago
|
||
The window IDL file needs to be fixed to remove the DOMWindow as a return value.
Popups aren't DOM windows anymore. Then the C++ implementation has to be fixed
so that it no longer returns a DOM window.
Reporter | ||
Comment 5•25 years ago
|
||
So since popups are no longer DOM windows, I assume that there will be no way of
closing a popup from Javascript once it is open? Something like:
popup = window.createPopup(document.getElementById('urlbar'),
document.getElementById('popup'), 0, 0, 'popup', 'topleft','topleft');
.
.
.
popup.close();
This is something I would need if I'm to emulate the IE style of URL completion.
Assignee | ||
Comment 6•25 years ago
|
||
Yes, there will be. I have a bug on that already marked for M14.
Assignee | ||
Comment 7•25 years ago
|
||
Will be an interface/API on the popup element itself.
Reporter | ||
Comment 8•25 years ago
|
||
I have fixed this bug in my tree. Will create & upload patches as soon as
patches from bug 22979 have been applied/cleared out of my tree.
Assignee | ||
Updated•25 years ago
|
Target Milestone: M17 → M14
Assignee | ||
Comment 9•25 years ago
|
||
createPopup needs to move onto the popup element eventually. I was thinking of
renaming it to "open" when I did this.
Pulling this bug in to M14. This should be done at the same time i add a
close() method to the popup element.
Updated•25 years ago
|
Assignee: hyatt → pinkerton
Status: ASSIGNED → NEW
Comment 10•25 years ago
|
||
Taking menu/popup bugs.
Comment 12•25 years ago
|
||
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL. XUL
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Assignee | ||
Comment 13•25 years ago
|
||
Moving to M15. Lowe, I'd love to have your patch to stop the crash. If I get
it earlier, I'll take it.
Status: NEW → ASSIGNED
Whiteboard: Awaiting patch from michael.lowe
Target Milestone: M14 → M15
Reporter | ||
Comment 14•25 years ago
|
||
Hyatt: hope you don't mind if I take this bug. I'll attach patch and ask you
to review it before I checkin.
Assignee: hyatt → michael.lowe
Status: ASSIGNED → NEW
Target Milestone: M15 → M14
Assignee | ||
Comment 15•25 years ago
|
||
Go for it.
Reporter | ||
Comment 16•25 years ago
|
||
Reporter | ||
Comment 17•25 years ago
|
||
Hyatt: have attached patch file for review. Please take a look when you get a
chance. Thanks. Michael
Reporter | ||
Comment 18•25 years ago
|
||
Reassign to hyatt for code review. Send back to me if you want me to checkin
this.
Assignee: michael.lowe → hyatt
Comment 19•25 years ago
|
||
putting on beta1 radar
Reporter | ||
Updated•25 years ago
|
Whiteboard: Awaiting patch from michael.lowe → Wating code review
Assignee | ||
Comment 21•25 years ago
|
||
I went ahead and removed createPopup, replacing it with openPopup.
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 22•25 years ago
|
||
please ignore, massive spam giving jrgm@netscape.com backlog of XPToolkits
resolved fixed bugs to verify
QA Contact: paulmac → jrgm
Comment 23•25 years ago
|
||
Adding crash keyword
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•