Closed Bug 24303 Opened 25 years ago Closed 25 years ago

[DOGFOOD][REGRESSION] Menus on bookmarks bar now have black text on dark bg after skin update...

Categories

(Core :: XUL, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: german, Assigned: hyatt)

References

Details

Attachments

(1 file)

...which is on a dark blue background, ie. not very legible. I am sure this was introduced with the much appreiated skin improvements hyatt performed on menus, this should be small thing to correct.
Attached image screenshot (deleted) —
QA Contact: paulmac → claudius
while you're at it fixing bookmark bar folders could you also add to the bmenu class: (this will give you proper hiliting on mouseover, as well as a proper pressed down look). Thanks!!! .bmenu { margin: 0px; padding: 1px; border: none; color: #99cccc; list-style-image: url("chrome://global/skin/toolbar-dropdown.gif"); } .bmenu:hover { color: #CCFFFF; background-color: #336699; } .bmenu:active { color: #CCFFFF; background-color: #336699; padding-left: 2px; padding-top: 2px; padding-right: 0px; padding-bottom: 0px; }
found the problem: somebdy renamed .bookmarkfolder to .bmenu in navigator.css, but left the navigator.xul file with class="bookmarkfolder" [approx. line 278]. thus the style did not go in effect for the folders on the bookmarks bar. Can yopu pls fix this? thanks!
Status: NEW → ASSIGNED
Target Milestone: M13
Target Milestone: M13 → M14
Doesn't fit criteria for M13, moving to M14
I was going to whine about this because it's a one-word fix, bookmarkfolder-->bmenu but it seems to already have been taken care of. Inspection of navigator.xul however shows me that someone did change class="bookmarkfolder" to class="bmenu" at or about line 231 but it still remains class="bookmarkfolder" at line 277. nonetheless, everything appears fine.
*** Bug 24263 has been marked as a duplicate of this bug. ***
Summary: Menus on bookmarks bar now have black text on dark bg after skin update... → [DOGFOOD] Menus on bookmarks bar now have black text on dark bg after skin update...
marking dogfood, I can't see my personal toolbar items. Recommend m13. Simple bmenu replacement for bookmarkfolder class didn't work for me, linux.
yeah so I was wrong. Turns out any populated directory on the personal toolbar will show up as black text, and be unreadable. Just for kicks, note that if the directory is empty its name shows up in the proper color.
Summary: [DOGFOOD] Menus on bookmarks bar now have black text on dark bg after skin update... → [DOGFOOD][REGRESSION] Menus on bookmarks bar now have black text on dark bg after skin update...
This is a regression.
I think it would be wrong to delay work on really critical bugs- blockers, crashers, etc - in order to fix a minor inconvenience like this, one with multiple workarounds at that! Why, we have yet to ship _any_ version of the browser on the Mac that even supports folders in the personal toolbar, a toolbar we didn't even offer Mac users until 4.5.
BTW, I can read these well enough on Mac & Linux in today's opt builds (can't even launch on Win98). Is it only a problem in certain bit-depths?
bug only happens for toplevel, personal toolbar items that are folders, that have contents. Which, is all of mine! I have a fix in my tree for this, r=hyatt.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Fixed. PToolbar items that are folders with contents will show up now.
Target Milestone: M14 → M13
Putting on M13 radar. Was this actually checked in?
yes, they are more legible today on Win98 & Linux.
VERFIED fixed with 2000012808 builds on all platforms
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: