Closed Bug 24830 Opened 25 years ago Closed 25 years ago

Font prefs not read from prefs.js; fonts reset after prefs used

Categories

(SeaMonkey :: Preferences, defect, P1)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: rzach, Assigned: matt)

References

Details

(Whiteboard: [PDT+])

Changing the font preferences does not result in new font prefs to be written to prefs.js, nor are the settings persistent across calls to the pref panel. To reproduce: 1. Edit | Preferences | Fonts Actual result: default fonts, default size of 8pts; screen resolution of 96. Expected result: these values should be taken from prefs.js, which contains the following lines: user_pref("browser.screen_resolution", 120); user_pref("font.size.fixed.x-western", 15); user_pref("font.size.variable.x-western", 18); 2. Change font sizes, screen resolution 3. Click OK Actual result: The prefs window is not dismissed, but the font size change takes effect in the browser window. (The text is redisplayed, but the page is not reformatted, so the output is garbled. That's bug 24343). The font values and screen resolution is not saved to prefs.js. If the prefs dialog is dismissed with cancel or close window, and then opened again, the old font sizes are still there. Console output: *** VALUE=x-western *** VALUE=8 *** VALUE=48 JavaScript Error: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPref.SetCharPref]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: chrome://pref/content/pref.js :: PREF_ParsePref :: line 151" data: no] Expected result: prefs dialog dismissed, font changes take effect, saved to prefs.js and remembered next time font prefs dialog is opened. Linux build 2000.01.23.09
*** Bug 24833 has been marked as a duplicate of this bug. ***
I take one thing back: The font sizes *are* saved in prefs.js. However, since they are not first read from prefs.js, you reset the font size to 8pt every time you change a font pref. The screen resolution is not saved to prefs.js.
I'm still trying to track this one down.
Status: NEW → ASSIGNED
is this beta stuff?
this is beta stuff
Summary: Font prefs not saved, not read from prefs.js → [BETA]Font prefs not saved, not read from prefs.js
*** Bug 25638 has been marked as a duplicate of this bug. ***
Changed summary, added beta1 to keywords. Review of problems reported here: 1. Font prefs not initialized from prefs.js. 2. Changed font sizes take effect but aren't changed when font prefs panel opened again. 3. OK changes font prefs, but doesn't dismiss prefs window. 4. Only changed font prefs should be saved/go into effect (right now, whnever you click OK without changing anything, the fonts revert to 8pt). 5. Screen resolution pref not saved to prefs.js. Let me know if you want separate bugs.
Keywords: beta1
Summary: [BETA]Font prefs not saved, not read from prefs.js → Font prefs not read from prefs.js; fonts reset prefs used
Summary: Font prefs not read from prefs.js; fonts reset prefs used → Font prefs not read from prefs.js; fonts reset after prefs used
*** Bug 25664 has been marked as a duplicate of this bug. ***
*** Bug 25874 has been marked as a duplicate of this bug. ***
johnlar@tfn.net reports that the font face is also not saved/read from prefs.js.
M14.
Priority: P3 → P1
Target Milestone: M14
I guess you also have to make sure that if there is not pref defined, the standard values for face/size are standard, and not the first font face in the list and the smallest font size (8pt).
*** Bug 25998 has been marked as a duplicate of this bug. ***
Yes, not only when it's undefined, but also when the user has edited the prefs file, and put some garbage font name in there (non-existent). The nsIPref API allows you to get the Mozilla defaults via GetDefaultCharPref().
*** Bug 26047 has been marked as a duplicate of this bug. ***
*** Bug 26052 has been marked as a duplicate of this bug. ***
marking as dogfood. this ranks up there as one of the Most Frequently Dup'd bugs for M13...
Summary: Font prefs not read from prefs.js; fonts reset after prefs used → [Dogfood] Font prefs not read from prefs.js; fonts reset after prefs used
Putting on the PDT+ radar for beta1.
Whiteboard: [PDT+]
*** Bug 26141 has been marked as a duplicate of this bug. ***
*** Bug 26215 has been marked as a duplicate of this bug. ***
*** Bug 24662 has been marked as a duplicate of this bug. ***
*** Bug 26486 has been marked as a duplicate of this bug. ***
Another problem seems to be that the font face change is neither saved nor do the standard browser fonts change when the selection in the pref UI is changed.
Putting dogfood in the keyword field.
Keywords: dogfood
Summary: [Dogfood] Font prefs not read from prefs.js; fonts reset after prefs used → Font prefs not read from prefs.js; fonts reset after prefs used
This should be fixed now. Please enter new bug for problems.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Verifying. New bugs for remaining problems filed: bug 27428, bug 27432.
Status: RESOLVED → VERIFIED
Bulk move of all Pref UI component bugs to new Preferences component. Pref UI component will be deleted.
Component: Pref UI → Preferences
*** Bug 29233 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.