I'm using M13 on Windows NT 4 an when I view an image only (tried gif and jpeg) an then choose view source, I get unknown file type dialog. To reproduce : 1) open mozilla 2) go at http://bugzilla.mozilla.org/ 3) click on the bug image, select "view image" 4) when image is loaded, select, either from menu or contextual menu, "view source" 5) Unknown file type dialog appears : "you are about to download a file of type image/jpeg This file is unrecognized by Mozilla. You can save it or open it with another application. More info... Save File pick App Cancel". Expected results : behavior should be similar to netscape 4.x Build ID 2000012520 on windows NT

Setting the keyword all open [4.xp] bugs to 4xp.

Confirmed with 2000-01-28-12-M14 nightly binary on Windows NT The dialog described in step 5 appears over an empty "Source for:" window. Testing NN 4.7, a dialog stating "Netscape is unable to locate the server (no name specified). Please check the server name and try again." appeared over an empty "Source for:" window. I don't see this as particularly superior to Mozilla's behaviour. What does make sense to me is that both the "View Source" menu item on the Context Menu and the "Page Source" item on the "View" menu should be greyed out when viewing an image, since there is no source to view. (Any textual information (comments) inside an image would be better presented by "View Info".) This looks like one of the other cases where "View Source" would best be greyed out expected in bug 24256, "View>Page Source can be recursive, probably shouldn't be", M15.

Bill, shouldn't this be your bug? (I re-assinged it to you from McAfee.)

The context menu aspect of the problem is my problem. It's not clear if the regular menus are already disabled but I'll try to take care of the whole problem. It's not that big a deal, I should think.

Move to M16 for now ...

Move to M20 target milestone.

pardon the spam: moving view source bugs into xp apps: gui component.

This one's easy :-) It's hardly worth preparing a patch... Line 134 of nsContextMenu.js from: this.showItem( "context-viewsource", !this.inDirList ); to: this.showItem( "context-viewsource", !( this.inDirList || this.onImage ) ); Gerv

what if i want to view the source of an SVG?

An SVG doesn't count as an image for the purposes of the code which sets that boolean (tested with Mozilla 0.8-SVG). So you are OK :-) Gerv

r=timeless. good answer, I presume you tested both inline and external svgs.

I can't test external SVGs as they require the Adobe plugin (at least, I think that's what you mean by "external". But that wouldn't have this menu either. Anyway, saying an SVG is an image makes as much sense as saying that MathML is. So, do I now need a sr=? I'm new at this... Gerv

Yes, you need a sr=. This code falls under the "xpfe" category described at http://www.mozilla.org/hacking/reviewers.html, so Alec Flett's the man. I've cc'd him.

easy enough..sr=alecf

Timeless, could you take 30s to check this in for me? I theoretically have checkin rights, but for the Bugzilla tree only. It would be very naughty for me to do it, as I haven't had 3 SR approval yet. Gerv

fix checked in

true, View Source is no longer available in the context menu for images. however, the View > Page Source menu item is still active when viewing the image on its own in the browser. and when you select that, you get the download/helper app dialog. i couldn't really find an existing/exact for that [bug 77337 only seems to deal with text files], so i filed another bug: bug 84542. marking this vrfy fixed --for the case of trying to view source from the context menu. :)

in light of bug 88918: iirc, i had tested this when the image was the only object in the page, eg, http://faqs.org/images/noframes.gif bug 88918 was found when i was viewing http://faqs.org...