Closed
Bug 2575
Opened 26 years ago
Closed 26 years ago
[PP] selection calls nsWindow->update and repaints too much
Categories
(Core :: Layout: Form Controls, defect, P2)
Tracking
()
M4
People
(Reporter: akkzilla, Assigned: mjudge)
Details
Pavlov says nsWindow->update is repainting the whole screen every time the
selection gets touched. Mjudge says it should only be calling it with the rect
which needs to be repainted to show selection highlighting (actually that would
be several rects, for the last selection going away and the new selection coming
in, I would assume).
Filing this as a reminder to look at it and compare Linux with Windows when I
have both builds available.
Not sure if this is PP or not, need to find out what Windows does.
Reporter | ||
Comment 2•26 years ago
|
||
This is an XP bug; we still don't know yet why it's repainting the whole screen
every time, but it's definitely happening on both Linux and the Mac (we're
guessing that it does the same thing on Windows but that painting is highly
optimized for that platform so it's not obvious to the eye).
Most likeley the problem is due to the fact it is calling nsIWidget->Update()
instead of nsIWidget->Invalidate() with a rect. Update is supposed to redraw
the entire widget, whereas Invalidate with a rect should just redraw the portion
you tell it to. (unless i'm missing something ovbious here)
Comment 4•26 years ago
|
||
On Windows, only the frame in which selection change are being redrawn. On
Mac & Linux, the entire screen is being redrawn -- you can see this in builds
with double buffering off.
Reporter | ||
Updated•26 years ago
|
Assignee: akkana → trudelle
Component: Editor → Widget Set
Summary: selection calls nsWindow->update and repaints too much → [PP] selection calls nsWindow->update and repaints too much
Reporter | ||
Comment 5•26 years ago
|
||
Could someone in the xpfe group, who understands when we're supposed to be
calling Invalidate() vs. Update(), please look at this?
Updated•26 years ago
|
Assignee: trudelle → rods
Comment 6•26 years ago
|
||
Rod, could you field this one?
Updated•26 years ago
|
Assignee: rods → mjudge
Comment 7•26 years ago
|
||
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Comment 9•26 years ago
|
||
Windows and Mac only repaint the frame in which selection changes, not the
entire screen. If linux is repainting the entire screen, then that's a different
bug to 3289 (which is XP).
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → DUPLICATE
Comment 10•26 years ago
|
||
i think this is a duplicate of 3289 (at this point) and can be closed.
*** This bug has been marked as a duplicate of 3289 ***
Comment 11•26 years ago
|
||
verified duplicate
Comment 12•26 years ago
|
||
Moving all Widget Set bugs, past and present, to new HTML Form Controls
component per request from karnaze. Widget Set component will be retired
shortly.
You need to log in
before you can comment on or make changes to this bug.
Description
•