Closed
Bug 25779
Opened 25 years ago
Closed 24 years ago
Alternate Cut/Copy/Paste keys do not work
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: hacker, Assigned: akkzilla)
References
Details
(Keywords: access, Whiteboard: fix in hand)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
The alternate copy/paste/cut key shortcuts do not work. In addition to
Ctrl-X/Ctrl-C/Ctrl-V keys, Windows and (I believe) Linux (under KDE/KDE-style
applications) allow Shift-Delete (cut), Ctrl-Ins (copy), and Shift-Insert
(paste) using both the numerical keypad and the 3x2 rectangle between the
numeric keypad and the QWERTY section.
kathy and Akkana own editor/text control key bindings. hyatt's been monkeying
around with that stuff lately as well.
question for submitter: what build are you using?
Assignee: buster → brade
Severity: enhancement → major
Summary: Alternate Cut/Copy/Paste keys do not work → [regression] Alternate Cut/Copy/Paste keys do not work
Comment 3•25 years ago
|
||
changing summary; this is not a regression
the following have not worked in mozilla (as far as I know):
Shift-Delete --> Cut
Control-Insert --> Copy
Shift-Insert --> Paste
Akkana--should Linux have these keybindings as well or just Windows?
Component: HTML Form Controls → Editor
Summary: [regression] Alternate Cut/Copy/Paste keys do not work → [4.xP][PP]Alternate Cut/Copy/Paste keys do not work
Comment 4•25 years ago
|
||
I have a fix for this for Windows but I haven't tested it yet. Please e-mail me
if you are interested in trying out the fix (before I commit it). Set to M14.
Status: NEW → ASSIGNED
Target Milestone: M14
Assignee | ||
Comment 5•25 years ago
|
||
Which Linux apps have these bindings? I had never heard of them myself, but
wouldn't object if it turned out someone wanted to add them and if it turns out
they're standard for a lot of Linux apps.
Reporter | ||
Comment 6•25 years ago
|
||
buster@netscape.com: I am using Windows M13, build 2000012520, running under
Windows 98 (not SE or OSR).
akkana@netscape.com: I'm pretty sure that the standard apps bundled with KDE use
these alternate keys, except that they only work on the 2x3 AT keypad (not the
numeric keypad). If memory serves me correctly (I rarely use Linux since it
doesn't fully support all of my hardware yet) then KEdit (which comes with KDE)
is one example of this. (I'll try dusting off my Linux partition and confirming
this later . . .) I also think that this is undocumented.
Comment 8•25 years ago
|
||
These keys seem to work under fvwm2 and fvwm95 on Linux with NN 4.7 and
Wordperfect 8.
Assignee | ||
Comment 9•25 years ago
|
||
Okay, if we supported them in 4.7/Unix, then I guess we should support them in
5.0, too.
Kathy, can you add them to Unix while you're adding them to Windows, or would
you rather I did it?
Updated•25 years ago
|
Summary: [4.xP][PP]Alternate Cut/Copy/Paste keys do not work → Alternate Cut/Copy/Paste keys do not work
Comment 11•25 years ago
|
||
*** Bug 27610 has been marked as a duplicate of this bug. ***
Updated•25 years ago
|
Target Milestone: M14 → M15
Comment 12•25 years ago
|
||
This should be tested on both Linux and Windows. These keybindings will not work
on Macintosh. These keybindings should be verified in single line edit fields (<
input>), textareas, and in Composer.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
OS: Windows 98 → All
Hardware: PC → All
Resolution: --- → FIXED
Comment 14•24 years ago
|
||
This may have regressed. It no longer works on Linux, at least.
Comment 15•24 years ago
|
||
Reopening...not working on Linux.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 16•24 years ago
|
||
*** Bug 66422 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 17•24 years ago
|
||
This is partly my fault. Shift-delete, at least, has never worked on linux (or
at least hasn't been working for a long time) and when it was fixed for Windows,
we discussed linux bindings and it was my opinion that most linux people would
not expect or want these bindings.
I have posted a request for comment in the mozilla-unix newsgroup to see whether
most people expect these bindings or not.
Assignee | ||
Comment 18•24 years ago
|
||
From bug 66422, xterm/rxvt/emacs apparently supports shift-insert as paste.
I just tested this:
In emacs, shift-insert pastes the CLIPBOARD selection (so, paste as in ^V, not
paste as in middle-mouse). Shift-delete does the same thing as delete (delete
backward character, ignoring the selection). Shift-insert indeed copies to the
clipboard selection.
In rxvt, shift-insert pastes the primary selection, just like middle mouse; cut
and copy don't apply, but DEL and shift-DEL insert characters on the command
line (and beep).
Sounds like we should implement shift-insert and control-insert, but not
necessarily shift-delete unless we can find some other linux app that uses it.
Assignee | ||
Comment 19•24 years ago
|
||
Stuart Ballard on mozilla-unix made a good point that the "cut" binding only
makes sense when text is selected, so shift-delete should do cut if something is
selected, and forward-delete-character (as now) when the selection is collapsed.
We don't actually have an editor command to do that (at least, I don't think we
do) so we'll have to write one (not difficult).
Should Windows use this binding as well? I.e. what should Windows do on
shift-delete when the selection is collapsed?
Kathy, do you want me to take this, or do you want to keep it?
Comment 20•24 years ago
|
||
reassign to akkana; Akkana--do you also want bug #61341 (alt-backspace-->undo)?
Assignee: brade → akkana
Status: REOPENED → NEW
Target Milestone: M15 → mozilla0.9
Assignee | ||
Comment 21•24 years ago
|
||
Accepting. As for bug 61341, nobody seems to be arguing for it or pointing
toward other apps which use that binding, so I'm inclined to skip that one
unless someone speaks up.
Status: NEW → ASSIGNED
Assignee | ||
Comment 22•24 years ago
|
||
Attaching patches now (two files, editor diffs and keybinding diffs). Could I
get a review from Anthony (or any other interested party within earshot) and an
sr from Simon? Thanks!
Assignee | ||
Comment 23•24 years ago
|
||
Oh, or Kathy for the review (especially for the key binding part).
BTW, I've made the changes in both Linux and Windows bindings files since nobody
commented one way or the other.
Assignee | ||
Comment 24•24 years ago
|
||
Assignee | ||
Comment 25•24 years ago
|
||
Assignee | ||
Comment 26•24 years ago
|
||
Oh, one other thing and I'll shut up: I didn't change the key bindings for the
browser window, because I don't know what controller handles them or why they're
there at all, or whether the browser has the concept of a collapsed selection.
Does anyone see this as a problem? The browser does have the bindings, they're
just not smart about handling collapsed selections.
Comment 27•24 years ago
|
||
sr=sfraser
Browser window's controller has no cut/delete commands on it, so these changes
need not be made there.
Assignee | ||
Comment 28•24 years ago
|
||
Thanks for the sr!
The Unix and Windows platformHTMLBindings.xml actually do include cut/paste
bindings for the browser window, which is why I brought it up (I don't
understand why those are there or what they do).
Maybe Aaron knows?
Comment 29•24 years ago
|
||
Akkana, no idea why cut/delete/paste would be in browser if it's not for text
fields and textareas. Sounds like anamalous.
Comment 30•24 years ago
|
||
the windows diff appears to have the wrong modifier (should be control not
shift); fix that and then r=brade
Assignee | ||
Comment 32•24 years ago
|
||
cvsblame says pinkerton added the cut and paste bindings for the browser window
to platformHTMLBindings.xml. Adding him, maybe he can tell us if they really
need to be there or if I can take them out as part of this bug fix. (Pink, the
issue is that the urlbar already has bindings for cut and paste, and we're
wondering what cut and paste in the browser window outside of the urlbar do and
what controller handles it.)
Comment 33•24 years ago
|
||
i didn't write these files, i just moved them from their previous location and
checked them into a new location for hyatt (embedding). notice that my name is
just on the 1.1 version.
Assignee | ||
Comment 34•24 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•