Closed Bug 26594 Opened 25 years ago Closed 25 years ago

not supporting unicode status messages in imap

Categories

(MailNews Core :: Backend, defect, P3)

All
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

(Whiteboard: [pdt-])

I never got around to supporting unicode status messages in the imap code, because I'm still using pr_smprintf.
Is this a beta blocker? Are we translating beta1? Nominating just in case.
Status: NEW → ASSIGNED
Keywords: beta1
Target Milestone: M14
can live with status message garbled for now - bobj please comment if you disagree
Whiteboard: [pdt-]
I want to be clear that I'm talking about things like "downloading header 1 of 5" and "no new messages" and "moving message to folder foo". I'm not talking about status messages from the imap server.
Beta1 is being localized. What type of IMAP status messages will be displayed? How will the user be impacted if s/he cannot read some of the messages? If we are not really relying upon the status messages to prompt user action, then we might be able to live with the garbled messages in Beta1. We could leave the generic parts of the messages in English (instead of garbled translations), but references to non-English items (e.g., folder names) would be garbled.
I didn't see bienvenu's latest comment before typing in my previous comment. It's not pretty, but we could leave those types of messages in English for Beta1.
David, Where are you storing those messages? string bundles? or ...? Even if you are using pr_smprintf in the imap code, don't you need to convert to PRUnichar to actually display the messages?
yeah, there in string bundles, but as I say, I haven't got around to using the unicode string formating routines.
The string bundles by definition are in Java escaped Unicode format. Is the outstanding task is to decode Java escaped Unicode (from the string bundle) to PRUnichar? If so, other code in Seamonkey already does this. If your imap libraries needed null-terminated char*, we could also convert to UTF-8. There's Seamonkey code does that too. Naoki can send you examples where we do these conversions elsewhere in Seamonkey. If it's something else, let us know how we might help.
Frank wrote nsTextFormatter.h which accepts unicode. http://lxr.mozilla.org/seamonkey/source/xpcom/ds/nsTextFormatter.h
I know all this, thanks. I'm not saying it can't be done; I'm saying I haven't done it, and I may not get a change to do it before beta because of other priorities.
I've fixed most of these. There are a few place where we don't support unicode folder names in status messages, but those aren't the normal status messages.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
QA Contact: lchiang → momoi
** Checked with 2/10/2000 Win32 build ** I used modified (in escaped Unicode) imapMsgs.properties file. I used Japanese translations. I don't claim to have checked every status msg but have confirmed with many of them like "Checking server capabilities...", "Document: Done", "Renaming ... folder", etc. that the status msgs at the bottom do show correctly and so is going through correct conversion. The ones which do not work are folder names which need to be loaded to substitute for "%.." variables. David, should we keep this bug open and set the target for later or should we open a new one for that later? Except for the above known limitation, I think this fix is working. There may be some special problems associated with certain strings in translation but those should be filed as separate bugs when L10n process begins in earnest for non-ASCII languages.
I'll open a new bug for those. Thanks for checking this.
Since we will have a new bug to deal with the remaining issue, I'll now mark this fix verified.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.