Closed Bug 26952 Opened 25 years ago Closed 25 years ago

margin not included in floater max_element-size calculation

Categories

(Core :: Layout: Tables, defect, P2)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: huttonr, Assigned: buster)

References

()

Details

(Keywords: testcase, Whiteboard: [TESTCASE])

Attachments

(1 file)

The image and the text are in separate columns, but the text displays over the image. Neither column has sizes specified, so table should auto size to elements.
Attached file Test case - contains page and graphic (deleted) —
Marking testcase ok, adjusting summary(from "displaying" to "adjusting column widths"), adding Status Whiteboard solution
Keywords: 4xp, testcase
Summary: Table not displaying correctly → Table not adjusting column widths correctly
Whiteboard: [TESTCASE] (attached testcase ok) When rendering tables, column widths should be automatically adjusted to fit table contents
The floating image is causing it to overlap. Reassigning to Kipp's bug list.
Assignee: karnaze → kipp
mine! mine mine mine! all mine! whoo-hoo!
Assignee: kipp → buster
floaters to M16
Target Milestone: M16
changed summary to reflect real problem.
Severity: normal → major
Status: NEW → ASSIGNED
OS: Linux → All
Priority: P3 → P2
Hardware: PC → All
Summary: Table not adjusting column widths correctly → hspace not included in image max_element-size calculation
Whiteboard: [TESTCASE] (attached testcase ok) When rendering tables, column widths should be automatically adjusted to fit table contents → [TESTCASE] fix in hand
My fix was just a band-aid. I have a much better, more general fix now. The problem was not that images didn't account for hspace in their max-element-size. Rather, the problem is that floaters in general don't account for their margin in max-element-size. It's not 4.xp, it's just a bug. diff: 5386c5402,5405 < aState.StoreMaxElementSize(floater, brc.GetMaxElementSize()); --- > nsSize mes = brc.GetMaxElementSize(); > mes.SizeBy(aMarginResult.left + aMarginResult.right, > aMarginResult.top + aMarginResult.bottom); > aState.StoreMaxElementSize(floater, mes);
Keywords: 4xp
Summary: hspace not included in image max_element-size calculation → margin not included in floater max_element-size calculation
fixed
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Whiteboard: [TESTCASE] fix in hand → [TESTCASE]
Marking VERIFIED FIXED on: - MacOS9 2000-07-06-08-M17 Commercial - Linux6 2000-07-09-20-M17 Commercial - Win98 2000-07-09-21-M17 Commercial
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: