Closed Bug 27408 Opened 25 years ago Closed 25 years ago

pref-advanced.xul accesskeys need to move to .dtd

Categories

(SeaMonkey :: Preferences, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: fergus, Assigned: bugs)

Details

/xpfe/components/prefwindow/resources/content/pref-advanced.xul This file contains 8 accesskey definitions which should be moved to the corresponding .xul file. The lines in question are as follows: <html:label for="advancedAlwaysLoadImages" accesskey="i" tabindex="0"> <html:label for="advancedJavaAllow" accesskey="j" tabindex="0"> <html:label for="javascriptEnabled" accesskey="r" tabindex="0"> <html:label for="javascriptAllowMailNews" accesskey="m" tabindex="0"> <html:label for="CSSAllow" accesskey="s" tabindex="0"> <html:label for="advancedMailFTP" accesskey="e" tabindex="0"> <html:label for="signonRememberSignons" accesskey="r" tabindex="0"> <html:label for="walletCaptureForms" accesskey="r" tabindex="0">
Correction: I should hvae said the definitions need to move to the corresponding **.DTD** file.
I'll take these...
Assignee: matt → ben
fix checked in.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Bulk move of all Pref UI component bugs to new Preferences component. Pref UI component will be deleted.
Component: Pref UI → Preferences
if verification is as easy as making sure those lines appear in the dtd file, cool, then 'verifyme' can be removed from keywords. otherwise, if there's additional functionality that needs testing here, i'd like some other [qa or otherwise] help on verifying this.
Verification should proceed as follows: 1) Have the English UI strings been moved from the .xul file to the .dtd file? 2) Does the UI in this file actually display correctly at runtime? 3) Does the entity name in the .xul file match the entity name in the .dtd file? If not, the string concerned will not display correctly (and probably will not display at all).
i noticed that signonRememberSignons and walletCaptureForms are not in pref-advanced.xul (nor their corresponding entities in pref-advanced.dtd). presume this is because they've been disabled for beta1. otherwise, those files look fine. (w/respect to fergus's steps 1 & 3 above; any problems w/2 should be addressed in a separate bug.)
Status: RESOLVED → VERIFIED
signonRememberSignons and walletCaptureForms are still in the product (hidden for beta of course). They have been moved from the pref-advanced panel to the wallet/single-signon specific panel, namely pref-wallet.xul and its corresponding dtd file.
Product: Browser → Seamonkey
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.