Closed
Bug 28114
Opened 25 years ago
Closed 25 years ago
Get AIX building for M14
Categories
(SeaMonkey :: General, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M14
People
(Reporter: jdunn, Assigned: jdunn)
References
Details
(Whiteboard: [PDT+]checking with jdunn to verify 02/23)
Attachments
(4 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
AIX is currently not building and I need a bunch of checkins for it
to build/run on M14. Since it built on M13, I consider this a regression.
There are 2 types of changes:
makefiles with unresolved symbols
(see http://bugzilla.mozilla.org/show_bug.cgi?id=18896
NS_IF_ADDREF changes (I worked out the issues with Scott Collins)
I will be adding the diffs for this.
I neew reviewers for these changes. Scott Collins and I worked on the
NS_IF_ADDREF changes: Basically AIX is having problems with
NS_IF_ADDREF when a 'const' member function is accessing a member variable.
The change is to apply NS_IF_ADDREF to the return variable.
There are 2 sets of these, the first, a bunch in layout.
I need a r=troy. See "NS_IF_ADDREF changes for Layout" attachment
(note I removed all instances of NS_DEF_PTR - since they weren't being used)
I need a r=dougt. See "xpinstall InstallVersion changes for NS_IF_ADDREF"
The second in xpinstall, in which I actually replaces a NS_DEF_PTR
with a different approach that scc suggested.
The final is just resolved symbol dependencies.
I need a r=cls for Makefile dependency changes for unresolved symbols
For the NS_IF_ADDREF, I have a quote from scc that these changes
would be "a good thing"
requesting beta1 approval
Keywords: beta1
QA Contact: asadotzler → jdunn
Comment 7•25 years ago
|
||
So Jim, this bug effectively removes all remaining uses and or mentions of the
"nsIPtr.h" macros, right? If so, then I can mark bug #23738 a duplicate of this
one.
This gets rid of all instances of NS_DEF_PTR's that are 'included'
in the unix build. However it doesn't remove all the #include "nsIPtr.h"
lines. So I think we will need to do a second pass... since they
should be removed.
Comment 10•25 years ago
|
||
Yes, it is included by 18 files that no longer need it. See
<http://lxr.mozilla.org/seamonkey/search?string=%23include+%22nsIPtr.h%22>
The "SizeTestXX" files still use it, and don't need to compile on all platforms.
I will submit a patch for this later.
Assignee | ||
Comment 11•25 years ago
|
||
Assignee | ||
Comment 12•25 years ago
|
||
*** Bug 27808 has been marked as a duplicate of this bug. ***
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 13•25 years ago
|
||
All changes checked in!
Assignee | ||
Comment 14•25 years ago
|
||
oops someone added some timer code in xpfe/browser/src... I need
to update the Makefile with the following:
Index: Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/src/Makefile.in,v
retrieving revision 1.33
diff -c -r1.33 Makefile.in
*** Makefile.in 2000/02/17 04:52:55 1.33
--- Makefile.in 2000/02/22 00:33:31
***************
*** 35,43 ****
EXTRA_DSO_LDOPTS = \
-L$(DIST)/bin \
-L$(DIST)/lib \
! -lxpcom \
-lmozjs \
! $(NSPR_LIBS) \
$(NULL)
include $(topsrcdir)/config/rules.mk
--- 35,43 ----
EXTRA_DSO_LDOPTS = \
-L$(DIST)/bin \
-L$(DIST)/lib \
! $(MOZ_COMPONENT_LIBS) \
-lmozjs \
! $(MOZ_TIMER_LIBS) \
$(NULL)
Comment 15•25 years ago
|
||
r=cls
Comment 16•25 years ago
|
||
*** Bug 28678 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•