Closed
Bug 282
Opened 26 years ago
Closed 26 years ago
XFE overrides color preferences after viewing frames
Categories
(MozillaClassic Graveyard :: XFE, defect, P3)
Tracking
(Not tracked)
VERIFIED
WONTFIX
People
(Reporter: ksw, Assigned: mcafee)
References
Details
Created by (ksw@dna.lth.se) on Wednesday, April 29, 1998 7:07:31 AM PDT
Additional Details :
All X Windows versions have a bug in the front end in which
the user preferences for colors are permanently overridden
after having viewed certain frames. Upon displaying a frame
the code attempts to set the _default_ colors, instead of
those of the document.
Patch available.
Assignee | ||
Comment 1•26 years ago
|
||
Please send me your patch if you still have it:
mcafee@netscape.com, maybe you've gotten this
checked in by now?
Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → WONTFIX
Assignee | ||
Comment 2•26 years ago
|
||
Can't fix w/o a patch, or need more info.
Assignee | ||
Updated•26 years ago
|
Status: RESOLVED → REOPENED
Assignee | ||
Updated•26 years ago
|
Component: Platform: Rhapsody → XFE
Resolution: WONTFIX → ---
Assignee | ||
Comment 3•26 years ago
|
||
Here's the patch which you asked for. The basic idea is that the xfe
was (since netscape 2.0) making the document's background colors the
default colors. Two things needed to be changed:
LO_SetDefaultColor --> LO_SetDocumentColor,
and then someone needed to actually install the user's prefences from
preferences.js as the default - this was being done simply because it
was happening for _every_ document.
Index: xfe.c
===================================================================
RCS file: /cvsroot/mozilla/cmd/xfe/xfe.c,v
retrieving revision 3.8
diff -r3.8 xfe.c
2024a2025,2029
> LO_Color *linkcolor = XP_NEW( LO_Color );
> LO_Color *vlinkcolor = XP_NEW( LO_Color );
> LO_Color *alinkcolor = XP_NEW( LO_Color );
> LO_Color *fgcolor = XP_NEW( LO_Color );
> LO_Color *bgcolor = XP_NEW( LO_Color );
2025a2031
>
2034,2043c2040,2065
< LO_SetDefaultColor (LO_COLOR_LINK,
< c[0].red >> 8, c[0].green >> 8, c[0].blue >> 8);
< LO_SetDefaultColor (LO_COLOR_VLINK,
< c[1].red >> 8, c[1].green >> 8, c[1].blue >> 8);
< LO_SetDefaultColor (LO_COLOR_ALINK,
< c[2].red >> 8, c[2].green >> 8, c[2].blue >> 8);
< LO_SetDefaultColor (LO_COLOR_FG,
< c[3].red >> 8, c[3].green >> 8, c[3].blue >> 8);
< LO_SetDefaultColor (LO_COLOR_BG,
< c[4].red >> 8, c[4].green >> 8, c[4].blue >> 8);
---
>
> linkcolor->red = c[0].red >> 8;
> linkcolor->green = c[0].green >> 8;
> linkcolor->blue = c[0].blue >> 8;
>
> vlinkcolor->red = c[1].red >> 8;
> vlinkcolor->green = c[1].green >> 8;
> vlinkcolor->blue = c[1].blue >> 8;
>
> alinkcolor->red = c[2].red >> 8;
> alinkcolor->green = c[2].green >> 8;
> alinkcolor->blue = c[2].blue >> 8;
>
> fgcolor->red = c[3].red >> 8;
> fgcolor->green = c[3].green >> 8;
> fgcolor->blue = c[3].blue >> 8;
>
> bgcolor->red = c[4].red >> 8;
> bgcolor->green = c[4].green >> 8;
> bgcolor->blue = c[4].blue >> 8;
>
> LO_SetDocumentColor (context, LO_COLOR_LINK, linkcolor);
> LO_SetDocumentColor (context, LO_COLOR_VLINK, vlinkcolor);
> LO_SetDocumentColor (context, LO_COLOR_ALINK, alinkcolor);
> LO_SetDocumentColor (context, LO_COLOR_FG, fgcolor);
> LO_SetDocumentColor (context, LO_COLOR_BG, bgcolor);
Index: pref.cpp
===================================================================
RCS file: /cvsroot/mozilla/cmd/xfe/src/pref.cpp,v
retrieving revision 3.3
diff -r3.3 pref.cpp
56a57,69
>
> LO_SetDefaultColor( LO_COLOR_LINK, fe_globalPrefs.links_color.red,
> fe_globalPrefs.links_color.green,
> fe_globalPrefs.links_color.blue );
> LO_SetDefaultColor( LO_COLOR_VLINK, fe_globalPrefs.vlinks_color.red,
> fe_globalPrefs.vlinks_color.green,
> fe_globalPrefs.vlinks_color.blue );
> LO_SetDefaultColor( LO_COLOR_FG, fe_globalPrefs.text_color.red,
> fe_globalPrefs.text_color.green,
> fe_globalPrefs.text_color.blue );
> LO_SetDefaultColor( LO_COLOR_BG, fe_globalPrefs.background_color.red,
> fe_globalPrefs.background_color.green,
> fe_globalPrefs.background_color.blue );
Assignee | ||
Updated•26 years ago
|
Status: REOPENED → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → WONTFIX
Assignee | ||
Comment 5•26 years ago
|
||
xfe is gone in the new world.
You need to log in
before you can comment on or make changes to this bug.
Description
•