Closed Bug 28640 Opened 25 years ago Closed 25 years ago

Accessing bookmarks menu causes exit crash

Categories

(Core Graveyard :: RDF, defect, P1)

x86
Windows 98
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dead, Assigned: waterson)

References

Details

(Whiteboard: [PDT+])

Attachments

(1 file)

On a current (2/21 early A.M.) Win98 build, I am crashing on exit in RDF.DLL if I have pulled down the bookmarks menu at all. This is an optimized build so I don't have a stack trace. This is highly reproduceable though, I tried: - Pulling down every menu except Bookmarks, and exiting. No crash. - Pulling down only the Bookmarks menu, and exiting. Crash.
*** Bug 28465 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Keywords: beta1
Priority: P3 → P1
Target Milestone: M14
missing some addrefs, patch on its way...
Attached patch proposed fix (deleted) — Splinter Review
rjc: gimme a quick code review, baby. the kNC_Child case in GetTarget() was forgetting to addref in both the local and internet search services. My changes to the menu code must've somehow caused this to trip.
I suck. Yep, these look great.
Putting on PDT+ radar for beta1.
Whiteboard: [PDT+]
fix checked in, r=rjc a=jevering.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
marking verified: Win 98: 2000022308
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: