Closed
Bug 28718
Opened 25 years ago
Closed 25 years ago
Biff does not work
Categories
(MailNews Core :: Backend, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M14
People
(Reporter: rzach, Assigned: alecf)
Details
(Whiteboard: [PDT+]fix in hand)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Biff does not work.
I have the biff interval set to 5 minutes, send myself a message and wait
patiently. New mail is not downloaded on POP accounts; thread pane and unread
message counts are not updated on IMAP accounts..
Not sure if this is covered in bug 24577. But I don't think so, since all my
passwords are saved, and I logged into all my accounts on startup.
Linux build 2000.02.21.09
Comment 3•25 years ago
|
||
It looks like this is being caused by the fact that the biff manager class isn't
receiving any server loaded notifications which it uses to add servers to its
biff list. I'm reassigning this to alecf.
Assignee: putterman → alecf
Assignee | ||
Comment 4•25 years ago
|
||
I broke this, and if I had gotten putterman to review my changes, he probably
would have caught this :)
I'll attach a patch in a few minutes.
Assignee | ||
Comment 5•25 years ago
|
||
Assignee | ||
Comment 6•25 years ago
|
||
so this patch is in the function LoadAccounts(), and does two things:
- reverses the order that identities/servers get loaded. I discovered that if
the account manager is open when the notification goes off, it queries the
number of identities immediately, which means the identities have to be loaded
before the notification goes off
- sends off a notification after the server is actually loaded.
LoadAccounts only happens once (as assured by m_accountsLoaded) so this
notification should only happen once for each server.
new servers will still get the notification when they are attached to an account
via nsMsgAccount::SetIncomingServer
Status: NEW → ASSIGNED
Whiteboard: fix in hand
Assignee | ||
Updated•25 years ago
|
Target Milestone: M14
Assignee | ||
Comment 7•25 years ago
|
||
I take that patch back, I have a slight change (I want to move the notification)
Assignee | ||
Comment 8•25 years ago
|
||
ok, new patch on the way.
I'm still doing the first item from the previous patch, but I've moved the
NotifyServerLoaded into nsMsgAccount::createIncomingServer()
This is consistent with nsMsgAccount::SetIncomingServer(), so that
NotifyServerLoaded is always called right after m_incomingServer is set, so
there should never be any timing/ordering difference between creating a new
server and loading one from disk.
Assignee | ||
Comment 9•25 years ago
|
||
Assignee | ||
Comment 10•25 years ago
|
||
I'm testing the fix now....putterman, do you mind reviewing while I test?
Comment 11•25 years ago
|
||
I'm applying the patch now.
Comment 12•25 years ago
|
||
Putting on PDT+ radar for beta1.
Whiteboard: fix in hand → [PDT+]fix in hand
Assignee | ||
Comment 13•25 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 14•25 years ago
|
||
Linux (2000-02-23-23 M14)
Biff works in POP and IMAP.
Thread pane and unread message counts are updated.
Comment 15•25 years ago
|
||
Win (2000-02-24-09 M14
Mac (2000-02-24-08 M14)
Set biff interval to 5 minutes, Biff works in POP and IMAP.
Thread pane and unread message counts are updated.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•