Closed Bug 28718 Opened 25 years ago Closed 25 years ago

Biff does not work

Categories

(MailNews Core :: Backend, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: rzach, Assigned: alecf)

Details

(Whiteboard: [PDT+]fix in hand)

Attachments

(2 files)

Biff does not work. I have the biff interval set to 5 minutes, send myself a message and wait patiently. New mail is not downloaded on POP accounts; thread pane and unread message counts are not updated on IMAP accounts.. Not sure if this is covered in bug 24577. But I don't think so, since all my passwords are saved, and I logged into all my accounts on startup. Linux build 2000.02.21.09
Nominate for beta1
Keywords: beta1
See also bug 28732.
It looks like this is being caused by the fact that the biff manager class isn't receiving any server loaded notifications which it uses to add servers to its biff list. I'm reassigning this to alecf.
Assignee: putterman → alecf
I broke this, and if I had gotten putterman to review my changes, he probably would have caught this :) I'll attach a patch in a few minutes.
Attached patch proposed fix (deleted) — Splinter Review
so this patch is in the function LoadAccounts(), and does two things: - reverses the order that identities/servers get loaded. I discovered that if the account manager is open when the notification goes off, it queries the number of identities immediately, which means the identities have to be loaded before the notification goes off - sends off a notification after the server is actually loaded. LoadAccounts only happens once (as assured by m_accountsLoaded) so this notification should only happen once for each server. new servers will still get the notification when they are attached to an account via nsMsgAccount::SetIncomingServer
Status: NEW → ASSIGNED
Whiteboard: fix in hand
Target Milestone: M14
I take that patch back, I have a slight change (I want to move the notification)
ok, new patch on the way. I'm still doing the first item from the previous patch, but I've moved the NotifyServerLoaded into nsMsgAccount::createIncomingServer() This is consistent with nsMsgAccount::SetIncomingServer(), so that NotifyServerLoaded is always called right after m_incomingServer is set, so there should never be any timing/ordering difference between creating a new server and loading one from disk.
Attached patch a better fix (deleted) — Splinter Review
I'm testing the fix now....putterman, do you mind reviewing while I test?
I'm applying the patch now.
Putting on PDT+ radar for beta1.
Whiteboard: fix in hand → [PDT+]fix in hand
checked in
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
QA Contact: lchiang → fenella
Linux (2000-02-23-23 M14) Biff works in POP and IMAP. Thread pane and unread message counts are updated.
Win (2000-02-24-09 M14 Mac (2000-02-24-08 M14) Set biff interval to 5 minutes, Biff works in POP and IMAP. Thread pane and unread message counts are updated.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: