Closed
Bug 29213
Opened 25 years ago
Closed 25 years ago
Plain text part double-formatted
Categories
(MailNews Core :: Composition, defect, P3)
MailNews Core
Composition
Tracking
(Not tracked)
RESOLVED
FIXED
M15
People
(Reporter: BenB, Assigned: rhp)
Details
Attachments
(2 files)
Reproduce:
Create a msg with the HTML editor with the following content and send it in
"Both plain text and HTML":
*hello* b@b.com
Actual result:
The plain text part reads:
**hello** b@b.com <"b@b.com">
(ignore the quotes, that's bug #29211)
Expected result:
The plain text part reads:
*hello* b@b.com
Proposed fix:
I guess, we first run the mail through the HTML enhancer
mozTXTToHTMLConv::ScanHTML and then convert the result to plain text. We should
convert the the result of the editor directly to plain text.
Assignee | ||
Comment 2•25 years ago
|
||
I've tried this in all sorts of combinations and I can't recreate this problem
on Win32 or Linux so I am marking as such.
- rhp
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 3•25 years ago
|
||
rhp,
see <news://news.mozilla.org/38B5EC8F.9060802@netscape.com> ("Mozilla source
tree is open... but..." in .seamonkey) for an example, look out for "VERY".
I tried it several times before filing that bug.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee | ||
Comment 4•25 years ago
|
||
Maybe I'm missing something, but please tell me what is wrong with the two
images that I have attached. The first is 4.x and the second is 5.x...they look
identical to me?
- rhp
Assignee | ||
Comment 5•25 years ago
|
||
Assignee | ||
Comment 6•25 years ago
|
||
Assignee | ||
Updated•25 years ago
|
Status: REOPENED → ASSIGNED
Reporter | ||
Comment 7•25 years ago
|
||
The problem is in the plain text part.
Mozilla and 4.x display only the HTML part, if available, in the msg view, so
you can see the problem only in their "View Source". You will find a "**VERY**"
there.
Assignee | ||
Comment 8•25 years ago
|
||
Ok, the text enhancement was being applied to the conversion of the HTML to
plain text on the sending operation. This shouldn't be done since we should be
sending the original "plain text" (not what we render to the user).
I have a fix in my tree and will checkin with everything else when the tree
opens for M15.
- rhp
Summary: Plain text part double-formatted → [FIXED] Plain text part double-formatted
Target Milestone: M15
Reporter | ||
Comment 9•25 years ago
|
||
rhp,
I don't understand you fully. What IMO should be done (and what 4.x basically
did) is the following:
The HTML source (what the user generated using the HTML editor) should be run
through ScanHTML and the output of this function send as HTML part.
The HTML source again (HTML part of the msg) should be run through
nsHTMLToTXTSinkStream (with OutputFormatted) and the output of this class send
as plain text part.
Guessed old code:
+------------------------------> HTML part
HTML source ---> ScanHTML ---+
+---> nsHTMLToTXTSinkStream ---> TXT part
Proposed new code:
+---> ScanHTML ------------------------------> HTML part
HTML source --+
+---> nsHTMLToTXTSinkStream -----------------> TXT part
Reporter | ||
Comment 10•25 years ago
|
||
> (and what 4.x basically did)
In effect, not in code. Since 4.x didn't have so much formatting functionality,
both shown versions would (propably) have in the same result.
Assignee | ||
Comment 11•25 years ago
|
||
Ok...after I looked at it again, I have it working the way you describe (in
theory).
- rhp
Reporter | ||
Comment 12•25 years ago
|
||
Good. Thanks for fixing.
Assignee | ||
Comment 13•25 years ago
|
||
Now working off of original input for HTML-TXT conversion.
- rhp
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Summary: [FIXED] Plain text part double-formatted → Plain text part double-formatted
Comment 14•25 years ago
|
||
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•