Closed Bug 29215 Opened 25 years ago Closed 24 years ago

[outline]no focus outlines drawn in dialogs

Categories

(SeaMonkey :: General, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: hewitt)

References

Details

(Whiteboard: [nsbeta3-][pdtp3])

DESCRIPTION: In some of Mozilla's dialogs, it is possible to use the TAB key to move around from form element to form element. This is consistent with most operating systems and with Mozilla's behavior in web pages. However, the other times this happens, there is a dotted outline drawn around the object that is focused. In the dialogs, there is no focus outline and it is impossible to tell what element has the focus without pressing the space bar to see which checkbox or radio button one happens to be on. This bug could probably be fixed with good use of the CSS 'outline' property in the CSS skin files for dialogs, with the rules in html.css used as an example. STEPS TO REPRODUCE: * open the "File|Open Web Location" or "Search | Find on this Page" dialogs. * Hit the tab key a few times * hit space bar, and, if you hit the tab key the right number of times, you will find that a radio button is focused without any visual indication ACTUAL RESULTS: * there is no focus outline indicating which element is focused EXPECTED RESULTS: * there should be a focus outline DOES NOT WORK CORRECTLY ON: * Linux, mozilla, 2000-02-24-15-M14 ADDITIONAL INFORMATION: This bug probably depends on a few other bugs (which are probably all really 2 bugs): bug 9809, bug 9816, bug 18579, bug 25258.
Depends on: 30671
I think I should have given this a different component initially, so changing and reassigning. Also, there's a tracking bug for outline drawing issues: bug 30671. Also, I'm not sure my comment on CSS is correct: I'm not sure why the rules in html.css aren't being used.
Assignee: shuang → trudelle
Component: User Interface: Design Feedback → XP Toolkit/Widgets
QA Contact: elig → jrgm
reassigning to pollmann, Eric, is this yours?
Assignee: trudelle → pollmann
From reading this report, it sounds like focus is shifting correctly, but the drawing is just not correct. Reading over bug 9809, (which bug 25258 was marked a dup of), bug 18579, and this report, it seems like they are all really one issue - or very closely related if not. Since Rod owns the other two, I'm handing this one to him. If not 'duplicate of', it probably 'depends on' the other two reports.
Assignee: pollmann → rods
changed summary
Status: NEW → ASSIGNED
Summary: no focus outlines drawn in dialogs → [outline]no focus outlines drawn in dialogs
mass-move to M16
Target Milestone: --- → M16
I think this is now invalid since we are switching over to XBL widgets. reassigning to hangas
Assignee: rods → hangas
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Target Milestone: M16 → M17
just a note: i had to vote for this one because today my wrist is injured and i need this TAB key navigation feature badly in order not to use the mouse...
Sending to German. This issue covers all skins and so I send it to you to see it get's closed. Giving it nsbeta3+
Assignee: hangas → german
Status: ASSIGNED → NEW
Keywords: nsbeta3
Whiteboard: [nsbeta3+]
Target Milestone: M17 → M18
Is this platform specific? It says OS: Linux and Platform:PC. Is this a CSS issue that we have to fix for that platform? Changing Component to User Interface: Design Feedback to get other folks in.
Status: NEW → ASSIGNED
Component: XP Toolkit/Widgets → User Interface: Design Feedback
It's PC/Linux because I tested only on Linux. It's almost definitely XP.
This needs to be done while we are cleaning up the widgets for both modernII and classic themes. Plan for modern is that we draw a light blue border around the widget that has the focus across platforms. Plan for classic is to try to emulate the platform as good as we can in the time given.
On Windows with the windows classic theme, I see focus indication pretty consistently on all dialogs. It's been working well for quite a while now, if I recall correctly. However, it's not perfect. When tabbing around, sometimes the focus hits an element that doesn't indicate it is focused, so you have to keep hitting tab until it returns to an indicative element.
Marking P2, sending to Joe.
Assignee: german → hewitt
Status: ASSIGNED → NEW
Priority: P3 → P2
There is no information in this bug indicating this is a high-profile problem. If the relevant dialogs are frequently seen in frequently used windows, please add that information and send back for reevaluation.
Priority: P2 → P3
Whiteboard: [nsbeta3+] → [nsbeta3+][pdtp3]
Target Milestone: M18 → Future
Marking nsbeta3- since pdt lowered the priority.
Whiteboard: [nsbeta3+][pdtp3] → [nsbeta3-][pdtp3]
Target Milestone: Future → M19
This has been fixed. Classic and Modern now show focus outlines pretty consistently. Focus is not yet perfect in Modern but I am opening a separate bug to track future focus polish.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Chaning the qa contact on these bugs to me. MPT will be moving to the owner of this component shortly. I would like to thank him for all his hard work as he moves roles in mozilla.org...Yada, Yada, Yada...
QA Contact: jrgm → zach
Component: User Interface Design → Browser-General
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.