Closed Bug 29267 Opened 25 years ago Closed 25 years ago

spaces in plaintext replies become unprintable characters

Categories

(MailNews Core :: Composition, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: akkzilla, Assigned: rhp)

Details

(Keywords: regression, Whiteboard: [PDT+])

Reply to a plaintext message using plaintext compose. Spaces, in the quoted text passed to the editor's InsertAsQuotation routine, have been mapped to unprintable characters with the high bit set, and don't display as spaces on many mailers, including our own (they display as question marks for me). This doesn't seem to happen every time, but when it does it makes plaintext mail unusable. I'm investigating.
I've seen them turned into character 0x3f (?) and into a regular space with the high bit set. Marking beta1 (can't use plaintext mail if people can't read your replies) and regression.
Keywords: beta1, regression
Not sure what changed, but I will look into it. I have a feeling something is going wrong when I need to strip CRLF's from the string to insert because the DOM doesn't (or didn't) deal with CRLF's. - rhp
Status: NEW → ASSIGNED
Summary: spaces in plaintext replies become unprintable characters → [FIXED] spaces in plaintext replies become unprintable characters
Target Milestone: M15
Ok, I have this fixed in my tree. If this is PDT worthy, I can check it in anytime. - rhp
Rich's fix seems to work in my Linux build (I'll continue to test to be sure). PDT team, PLEASE mark this PDT+, since plaintext mail isn't usable without it.
PDT+
Whiteboard: [PDT+]
We were needlessly converting entities in plain text...removing that fixed the problem. - rhp
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Summary: [FIXED] spaces in plaintext replies become unprintable characters → spaces in plaintext replies become unprintable characters
Assign this bug to me.
QA Contact: lchiang → fenella
Linux (2000-02-29-08 M15) Win32 (2000-02-29-09 M15) Mac (2000-02-29-08 M15) The problem has been fixed. Replying to a plaintext message using plaintext compose, the space in the quoted text looks fine in display and in printing.
Status: RESOLVED → VERIFIED
I think, rhp's fix for this bug was not to use the flowed class for quoting. This opened bug 39370, which I'm trying to fix now (patch attached there). Does somebody (akk?) remember how to reproduce this bug, so I can make sure I don't cause a regression on this bug?
OK, nobody gave a reproduction. It looks fine to me, I never saw the bug, neither with or without my patches. I will just let it being checked in and then ask fenella to VERIFY this bug again.
I have not verified this bug. Just wonder who mark it verified?
I know I did it back on 2/29/2000. But I have not re-verified it yet.
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.