Closed Bug 29487 Opened 25 years ago Closed 24 years ago

[FIX]Window Class should not contain "Netscape"

Categories

(SeaMonkey :: General, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dean_tessman, Assigned: rods)

References

()

Details

(Whiteboard: [nsbeta3+]Fix in Hand)

Attachments

(1 file)

The window class for all windows created is "NetscapeWindowClass". This should be changed to "MozillaWindowClass" for the NPL version. This has to be changed in two places, one in nsWindow.cpp and one in the windows config.it file for xpinstall. I'll attach a patch to make these changes.
Attached patch Here's the patch. (deleted) — Splinter Review
reassigning to kmcclusk, and cc:ing ssu, who uses that label in config.it. dean_tessman@hotmail.com: you can figure out who the right owner for these things are yourself! head over to http://lxr.mozilla.org/seamonkey. search for a term, which will return a list of files. open each file, and at the top of every file, you'll see a link that says "CVS Blame". that will show you who wrote every line of code in that file.
Assignee: cbegle → kmcclusk
You know, I found this last night after I submitted this bug. Of course, I didn't bridge the gap between this and figuring out who to assign it to. I'll try and do that from now on. I just wasn't really sure about this one because it affects both the installer and the overall Win32 build. OK, the mouse-over comments in the CVS Blame view are really cool.
confirming this bug to move it form the new bugs list.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → ASSIGNED
Target Milestone: --- → M17
Reassigning to Rod.
Assignee: kmcclusk → rods
Status: ASSIGNED → NEW
Target Milestone: M17 → M18
Status: NEW → ASSIGNED
Keywords: nsbeta3
Summary: Window Class should not contain "Netscape" → [FIX]Window Class should not contain "Netscape"
Whiteboard: Fix in Hand
Marking nsbeta3-. Mozilla community members could take on the responsibility for the bug by checking in through Mozilla's standard process.
Whiteboard: Fix in Hand → [nsbeta3-]Fix in Hand
adding patch keyword
Keywords: patch
Marking nsbeta3+. Rod has fix.
Whiteboard: [nsbeta3-]Fix in Hand → [nsbeta3+]Fix in Hand
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Confirmed by looking at lxr. However, there still is one reference to NetscapeWindowClass in uninstall.it. It's commented out, so it isn't hindering this bug, but it should probably be changed as well. http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/windows/uninstall.it#65
Status: RESOLVED → VERIFIED
Good catch on the uninstall, I just checked it in for completeness
It now be perfect. Can't find "NetscapeWindowClass" anywhere.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: