There are two versions of XP_QSORT, one in lib/xp/xp_qsort.c, the other is embedded in modules/libimg/src/xpcompat.cpp. I believe the xp version is the right one, this is the one slamm sanitized last April. Only Solaris and Mac were using the libimg one, I've changed Solaris to use the XP one, leaving Mac as the sole (possible) client of the libimg version. Mac should probably move over to the xp version, XP_QSORT() is a utility function that doesn't belong in libimg.

Reassigning to pnunn since the dupe is in her area. CC:'ing pierre in case there's soemthing that needs to be changed in core Gecko.

No problem in core code: the duplicated function can be removed. FYI, there is that comment below in xpcompat.cpp which gives a very bad excuse for why we have duplicated entire functions. /* * The purpose of this file is to help phase out XP_ library * from the image library. In general, XP_ data structures and * functions will be replaced with the PR_ or PL_ equivalents. * In cases where the PR_ or PL_ equivalents don't yet exist, * this file (and its header equivalent) will play the role * of the XP_ library. */

fixed.

reopening, assigning to pierre.

This is a mac issue, XP_QSORT() needs to live in a dynamic library, lib/xp is not part of that world yet.

There are other functions that should be removed from xpcompat.cpp (at least XP_GetString and the FE_ timer functions). Ideally, the whole file should go away. On Mac, several of these stub functions used to overwrite the 'real' functions implemented somewhere else. It might even still be the case for XP_GetString.

putting on the radar so this doesn't hide too long.

Puhing my Mac-specific bugs to M9 before reassigning them to someone else.

Reassigned to dcone

dcone added a comment of " ", gee that's useful. Marking verified.

Dcode: did anything actually get fixed when this bug was marked FIXED? /be