Here is a patch to clean up the debug robot somewhat, and get it working again in the viewer test program: http://www.geocities.com:80/SiliconValley/Haven/8120/robot.txt It is not yet completely working in the viewer, but this patch gets it a long way there.

per leger, assigning QA contacts to all open bugs without QA contacts according to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser

Verified REMIND

REMIND is deprecated.

->harishd (do we still care about the debug robot?)

Choess: I've never used it and probably will never be used. IMO, we can remove that file. FUTURING the bug for now.

bz, since you've been interested in parser lately, do you think you could just tear out the robot directory entirely? It evidently hasn't been used or missed for years.

What does it do? Could it be useful for the layout debugger to get it working?

It seems to have been something hooked up in the Viewer app to automatically parse a collection of HTML documents. It looks like it was intended to pass a stream listener to the parser which would presumably collect debug information emitted by the parser, but the comments suggest it was never hooked up.

The debug robot doesn't work anymore (it was apparently written before the parser could parse a real stream), its content sink doesn't QI to all of the right things, and it's just generally a mess. I'll rip it out.

This is a diff -N of the removal. The only real interesting change here is the makefile change (first file in the diff).

Comment on attachment 189791 [details] [diff] [review] diff -N of the removal viewer depends on the debug robot, we should move it there instead of removing it.

Or just remove viewer.

So let's get this patch updated and remove this :-)

let's just remove it from the build. (cvs removing the files can be done to files that aren't part of a build at any time)

Comment on attachment 306238 [details] [diff] [review] remove it from the build I'm all for this, do we need to remove viewer (comment 11) at the same time?

Viewer was removed in bug 121881, slightly over two years ago.

Comment on attachment 306238 [details] [diff] [review] remove it from the build Just throwing this out there: robot isn't used by anything anymore. This patch doesn't include the removal of the robot directory and the files/dirs in it, see comment 14 for that.

Comment on attachment 306238 [details] [diff] [review] remove it from the build a1.9+=damons

Comment on attachment 306238 [details] [diff] [review] remove it from the build mozilla/parser/htmlparser/Makefile.in 1.14

(In reply to comment #17) > This patch doesn't include the removal of the robot directory and the > files/dirs in it, see comment 14 for that. These were later removed by {{ 2008-03-16 13:30 timeless%mozdev.org ... Bug 3004 Remove debug robot from build removed robot from the build, this removes it from cvs NPOB toolkit changes r=luser, a=luser }}