Closed Bug 30184 Opened 25 years ago Closed 25 years ago

User is prompted twice when he cancels out of supplying master password

Categories

(SeaMonkey :: Passwords & Permissions, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: morse, Assigned: morse)

Details

(Whiteboard: [PDT+])

Go to a site containing a login form in its content Fill in username and password Submit form Dialog appears asking if you want to save Answer yes Dialog appears asking for your master password Press cancel That should be the end of it. But, unfortunately it isn't. Instead the browser confronts you for a second time asking for your master password. That is wasn't supposed to do. Same problem exists for login forms generated by the browser, such as http authentication, mail password requests, etc. Furthermore, if you select OK instead of cancel on this second master-password prompt, the results are unpredictable. I'm not sure, but looking at the code it might be the case that your old saved signons could become deleted. I know exactly what is causing the problem and will have a very simple fix available in a few minutes.
Marking this for beta 1. It may sound like a minor point but it is embarrassing behavior for the feature to ask you the same question two time in a row after you already pressed Cancel the first time. And worse is the unpredictable behavior if you say OK the second time.
Status: NEW → ASSIGNED
Keywords: beta1
Target Milestone: M14
Fix in hand. It's been code reviewed and approved for checkin. Waiting for the tree to open.
Fix checked in. It was in singsign.cpp.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
marking PDT+ so it will get prompt verification :-)
Whiteboard: [PDT+]
verif w/opt comm bits on winNT and linux, as well as opt mozilla bits on mac [2000.03.07.09].
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.