Closed
Bug 30470
Opened 25 years ago
Closed 24 years ago
"Ends With" searches not implemented, causes asserts when mail filters use them
Categories
(MailNews Core :: Backend, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M18
People
(Reporter: trudelle, Assigned: Bienvenu)
Details
(Whiteboard: fix in hand)
There is an assertion in mailnews/base/search/src/nsMsgSearchTerm.cpp, line 836,
that is firing repeatedly on GetMsg, apparently due to lack of support for 'Ends
With' in message filters. Assigning to bienvenu as CVS Blame says he put it there.
Assignee | ||
Comment 1•25 years ago
|
||
this hasn't changed in about 5 months, so my guess is that you added this filter
recently. If that's not true, please let me know because something must be
horribly horribly wrong.
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•25 years ago
|
||
I think that's correct, and probably didn't have any EndsWith criteria
previously. I usually run the verification builds, so I didn't notice it right away.
Assignee | ||
Comment 3•25 years ago
|
||
changing summary.
Summary: Assert firing dozens of times on every GetMsg → "Ends With" searches not implemented, causes asserts when mail filters use them
Assignee | ||
Comment 4•25 years ago
|
||
Scott's working on the search backend now. Feel free to assign back to me if you
want, Scott.
Assignee: bienvenu → mscott
Status: ASSIGNED → NEW
Putting on [nsbeta2-] radar. Not critical to beta2.
Whiteboard: [nsbeta2-]
Assignee | ||
Comment 8•24 years ago
|
||
taking, nominating for nsbeta2 since search is now in and users could try this
and not get their search hits.
Assignee: mscott → bienvenu
Whiteboard: [nsbeta2-]
Comment 9•24 years ago
|
||
Putting on [nsbeta2-] radar. Not critical to beta2. Can we just remove the
"Ends With" search option?
Whiteboard: [nsbeta2-]
Assignee | ||
Comment 10•24 years ago
|
||
No, I'd rather not just remove the ends with search option. Do you have a
particular reason for thinking this is dangerous or hard? I'd rather not put up
with all the filter users whining that they can't use their ends with filter
criteria.It will take less time to fix it than it does to deal with all the
whining. Or arguing about whether we should do it. It's not going to break any
other piece of code.
Status: NEW → ASSIGNED
Comment 11•24 years ago
|
||
David - is search and filter the same code? The bug originally talks about
searches and then you comment about filters.
Assignee | ||
Comment 12•24 years ago
|
||
filters use the search backend to do the filter comparisons.
Comment 13•24 years ago
|
||
nominate for nsbeta3. Pls approve since we don't want users' existing criteria
for filters to suddenly not work!
Keywords: nsbeta3
Target Milestone: M17 → M18
Assignee | ||
Updated•24 years ago
|
Keywords: nsbeta2 → correctness
Whiteboard: [nsbeta2-]
Assignee | ||
Updated•24 years ago
|
Whiteboard: fix in hand
Assignee | ||
Comment 14•24 years ago
|
||
fixed (for the non 1i8n case).
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 15•24 years ago
|
||
Works ok with filters using sep 12 commercial build, linux rh6.0, NT 4.0 and mac
OS 9.0 IMAP and POP.
Can't verify for search until bug 52299 is resolved.
Comment 16•24 years ago
|
||
I'm tired of seeing this bug on my resolved list.
I won't be able to truly verify this in 6.5 because the two bugs blocking
verification aren't going to be fixed in 6.5. They are bug 60514 and bug 57034.
I'm going to assume it's okay, especially since it was verified in filters.
Marking verified.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•