Closed Bug 30470 Opened 25 years ago Closed 24 years ago

"Ends With" searches not implemented, causes asserts when mail filters use them

Categories

(MailNews Core :: Backend, defect, P3)

x86
Windows 98
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: trudelle, Assigned: Bienvenu)

Details

(Whiteboard: fix in hand)

There is an assertion in mailnews/base/search/src/nsMsgSearchTerm.cpp, line 836, that is firing repeatedly on GetMsg, apparently due to lack of support for 'Ends With' in message filters. Assigning to bienvenu as CVS Blame says he put it there.
this hasn't changed in about 5 months, so my guess is that you added this filter recently. If that's not true, please let me know because something must be horribly horribly wrong.
Status: NEW → ASSIGNED
I think that's correct, and probably didn't have any EndsWith criteria previously. I usually run the verification builds, so I didn't notice it right away.
changing summary.
Summary: Assert firing dozens of times on every GetMsg → "Ends With" searches not implemented, causes asserts when mail filters use them
QA Contact: lchiang → laurel
Scott's working on the search backend now. Feel free to assign back to me if you want, Scott.
Assignee: bienvenu → mscott
Status: ASSIGNED → NEW
Mail review recommends nsbeta2.
Keywords: nsbeta2
Putting on [nsbeta2-] radar. Not critical to beta2.
Whiteboard: [nsbeta2-]
Targetting our beta2 candidates to M17.
Target Milestone: --- → M17
taking, nominating for nsbeta2 since search is now in and users could try this and not get their search hits.
Assignee: mscott → bienvenu
Whiteboard: [nsbeta2-]
Putting on [nsbeta2-] radar. Not critical to beta2. Can we just remove the "Ends With" search option?
Whiteboard: [nsbeta2-]
No, I'd rather not just remove the ends with search option. Do you have a particular reason for thinking this is dangerous or hard? I'd rather not put up with all the filter users whining that they can't use their ends with filter criteria.It will take less time to fix it than it does to deal with all the whining. Or arguing about whether we should do it. It's not going to break any other piece of code.
Status: NEW → ASSIGNED
David - is search and filter the same code? The bug originally talks about searches and then you comment about filters.
filters use the search backend to do the filter comparisons.
nominate for nsbeta3. Pls approve since we don't want users' existing criteria for filters to suddenly not work!
Keywords: nsbeta3
Target Milestone: M17 → M18
Keywords: nsbeta2correctness
Whiteboard: [nsbeta2-]
Whiteboard: fix in hand
fixed (for the non 1i8n case).
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Works ok with filters using sep 12 commercial build, linux rh6.0, NT 4.0 and mac OS 9.0 IMAP and POP. Can't verify for search until bug 52299 is resolved.
I'm tired of seeing this bug on my resolved list. I won't be able to truly verify this in 6.5 because the two bugs blocking verification aren't going to be fixed in 6.5. They are bug 60514 and bug 57034. I'm going to assume it's okay, especially since it was verified in filters. Marking verified.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.