Closed
Bug 31136
Opened 25 years ago
Closed 24 years ago
Rename prefs from "browser.xxx" to "browser.display.xxx"
Categories
(SeaMonkey :: Preferences, defect, P3)
SeaMonkey
Preferences
Tracking
(Not tracked)
VERIFIED
FIXED
M18
People
(Reporter: pierre, Assigned: pierre)
Details
(Whiteboard: [nsbeta2+])
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
This bug is extracted from bug 29304.
The following prefs:
browser.background_color
browser.foreground_color
browser.use_document_fonts
browser.use_document_colors
browser.base_font_scaler
browser.wfe.use_windows_colors
browser.screen_resolution
should be renamed as "browser.display.xxx" instead of "browser.xxx".
Changing component to Preferences
Assignee: neeti → matt
Component: Preferences: Backend → Preferences
Comment 3•24 years ago
|
||
Comment 5•24 years ago
|
||
fixed.
QA: try setting some colors in prefs and make sure they
have a "browser.display" prefix. Oh yeah, color pref window
is busted so ? might need to hand-test. Or you can just take
my word for it that the changes went in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 6•24 years ago
|
||
yep, they're working --testing on linux [opt comm, 2000.05.18.08] with these
prefs:
browser.display.background_color
browser.display.screen_resolution
browser.display.use_document_fonts
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 7•24 years ago
|
||
Sorry, I was on vacation last week and did not have an opportunity to review the
code until now. I'm reopening the bug for a small but important code change. The
goal of this bug (and the result of the long discussion we had in bug 29304) was
to remove all the RegisterCallback()s from nsPresContext.cpp and replace them
with a single:
RegisterCallback("browser.display.", PrefChangedCallback, (void*)this);
and then ask people who want a new pref to cause a reflow when it changes to call
it "browser.display.<something>".
Chris, it's a 2-line change. Feel free to reassign to me if you want.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 8•24 years ago
|
||
I did the dirty work, looks like we need to turn it on now.
pierre, can you drive this one?
Assignee: mcafee → pierre
Status: REOPENED → NEW
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•24 years ago
|
||
Marking nsbeta2/fix in hand. Very simple fix...
Keywords: nsbeta2
Whiteboard: [fix in hand]
Assignee | ||
Comment 10•24 years ago
|
||
Comment 11•24 years ago
|
||
Putting on [nsbeta2+] radar. Patch appears low risk. Approved to checkin for
patch as shown.
Whiteboard: [fix in hand] → [nsbeta2+]
Assignee | ||
Comment 12•24 years ago
|
||
Fix checked in nsPresContext.cpp
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•