Closed Bug 31887 Opened 25 years ago Closed 24 years ago

images in scrollbarbutton are not centered

Categories

(Core :: XUL, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: ian, Assigned: bugs)

References

()

Details

Images in scollbarbuttons are not centered, so if something causes the scroll bar buttons to be bigger than the image they contain, the image will look off-center. You can see this here: http://www.bath.ac.uk/%7Epy8ieh/internet/projects/mozilla/widgets/15.html ...at the moment. I am no XUL expert, but I think that adding: <xul:spring flex="1"/> ...either side of the <xul:image inherits="src"/> line should do the trick. This is what has already been done so that the image on the thumb is centered correctly. Thus I submit that the following would be a better binding for "scrollbar" in xulBindings.xml: <binding name="scrollbar"> <content> <xul:scrollbarbutton type="decrement"> <xul:spring flex="1"/> <xul:image inherits="src"/> <xul:spring flex="1"/> </xul:scrollbarbutton> <xul:slider flex="1" inherits="curpos,maxpos,pageincrement,increment"> <xul:thumb inherits="align,src" flex="1"/> </xul:slider> <xul:scrollbarbutton type="increment"> <xul:spring flex="1"/> <xul:image inherits="src"/> <xul:spring flex="1"/> </xul:scrollbarbutton> </content> </binding> hyatt: I'm assigning this direct to you since you created that code.
blah
Assignee: hyatt → ben
that's right, reimplement all your widgets in XBL, get them to limp and reassign all bugs to me! lazy bastard! (cc'ing you to increase the spam you receive as a punishment)
Status: NEW → ASSIGNED
Component: XP Toolkit/Widgets: XBL → XP Toolkit/Widgets
Target Milestone: --- → M18
Target Milestone: M18 → M21
Move to M21 target milestone.
I don't think this is a problem in any of today's skins.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.