Closed
Bug 31985
Opened 25 years ago
Closed 18 years ago
make cvsmailfilter use the checker-in in the From: line
Categories
(Webtools Graveyard :: Despot, enhancement, P3)
Webtools Graveyard
Despot
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dmosedale, Assigned: reed)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 1•24 years ago
|
||
Mass re-assign of despot bugs to endico@mozilla.org, the new owner. I'm
switching groups to go work on mozilla LDAP integration.
Status: ASSIGNED → NEW
Reporter | ||
Comment 2•24 years ago
|
||
Another try at mass-reassigning my Despot bugs to endico.
Assignee: dmose → endico
Comment 3•19 years ago
|
||
reassigning endico's Despot bugs to the default component owner
Assignee: endico → justdave
QA Contact: mattyt-bugzilla → timeless
Updated•19 years ago
|
Summary: make cvsmailter use the checker-in in the From: line → make cvsmailfilter use the checker-in in the From: line
Comment 4•18 years ago
|
||
Hmm... On the one hand I really like this idea. On the other hand, it's going
to confuse Mailman when trying to approve posts to the newsgroup.
Assignee | ||
Updated•18 years ago
|
QA Contact: timeless → despot
Assignee | ||
Comment 5•18 years ago
|
||
Since we can't actually change the sending e-mail address, set the "Person, system, or process name" portion of the "MAIL FROM" command to the committer's username.
Comment 6•18 years ago
|
||
Comment on attachment 247649 [details] [diff] [review]
patch - v1
The SMTP MAIL FROM command can only contain the email address it's being sent from. In fact, I'm surprised it worked like it was, it's supposed to be surrounded by angle brackets.
You need to edit the From: line within the message headers, and not fiddle with the SMTP envelope.
Attachment #247649 -
Flags: review?(justdave) → review-
Assignee | ||
Comment 7•18 years ago
|
||
Use the "From:" header instead. Also, clean-up some of the code by adding missing <>s and removing unneeded double space.
Attachment #247649 -
Attachment is obsolete: true
Attachment #247657 -
Flags: review?(justdave)
Updated•18 years ago
|
Attachment #247657 -
Flags: review?(justdave) → review+
Comment 8•18 years ago
|
||
Comment on attachment 247657 [details] [diff] [review]
patch - v2
err... most of our usernames contain dots in them (@mozilla.com, etc). rfc2822 says if the realname portion of the address contains a dot it has to be quoted.
Attachment #247657 -
Flags: review+ → review-
Assignee | ||
Comment 9•18 years ago
|
||
Add quotes.
Attachment #247657 -
Attachment is obsolete: true
Attachment #248346 -
Flags: review?(justdave)
Comment 10•18 years ago
|
||
Comment on attachment 248346 [details] [diff] [review]
patch - v3
this'll do. :)
Attachment #248346 -
Flags: review?(justdave) → review+
Comment 11•18 years ago
|
||
Checking in cvsmailfilter.pl;
/cvsroot/CVSROOT/cvsmailfilter.pl,v <-- cvsmailfilter.pl
new revision: 1.11; previous revision: 1.10
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 12•18 years ago
|
||
Nelson: heads up on this just in case it causes any problems with stuff clearing the crypto-checkins list. I doubt it will, since the actual email address stayed the same, it was just the comment part of the From line that changed. Should be more readable on the newsgroup. :)
Updated•8 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•