Closed Bug 31985 Opened 25 years ago Closed 18 years ago

make cvsmailfilter use the checker-in in the From: line

Categories

(Webtools Graveyard :: Despot, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dmosedale, Assigned: reed)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Status: NEW → ASSIGNED
Mass re-assign of despot bugs to endico@mozilla.org, the new owner. I'm switching groups to go work on mozilla LDAP integration.
Status: ASSIGNED → NEW
Another try at mass-reassigning my Despot bugs to endico.
Assignee: dmose → endico
reassigning endico's Despot bugs to the default component owner
Assignee: endico → justdave
QA Contact: mattyt-bugzilla → timeless
Summary: make cvsmailter use the checker-in in the From: line → make cvsmailfilter use the checker-in in the From: line
Hmm... On the one hand I really like this idea. On the other hand, it's going to confuse Mailman when trying to approve posts to the newsgroup.
QA Contact: timeless → despot
Attached patch patch - v1 (obsolete) (deleted) — Splinter Review
Since we can't actually change the sending e-mail address, set the "Person, system, or process name" portion of the "MAIL FROM" command to the committer's username.
Assignee: justdave → reed
Status: NEW → ASSIGNED
Attachment #247649 - Flags: review?(justdave)
Comment on attachment 247649 [details] [diff] [review] patch - v1 The SMTP MAIL FROM command can only contain the email address it's being sent from. In fact, I'm surprised it worked like it was, it's supposed to be surrounded by angle brackets. You need to edit the From: line within the message headers, and not fiddle with the SMTP envelope.
Attachment #247649 - Flags: review?(justdave) → review-
Attached patch patch - v2 (obsolete) (deleted) — Splinter Review
Use the "From:" header instead. Also, clean-up some of the code by adding missing <>s and removing unneeded double space.
Attachment #247649 - Attachment is obsolete: true
Attachment #247657 - Flags: review?(justdave)
Attachment #247657 - Flags: review?(justdave) → review+
Comment on attachment 247657 [details] [diff] [review] patch - v2 err... most of our usernames contain dots in them (@mozilla.com, etc). rfc2822 says if the realname portion of the address contains a dot it has to be quoted.
Attachment #247657 - Flags: review+ → review-
Attached patch patch - v3 (deleted) — Splinter Review
Add quotes.
Attachment #247657 - Attachment is obsolete: true
Attachment #248346 - Flags: review?(justdave)
Comment on attachment 248346 [details] [diff] [review] patch - v3 this'll do. :)
Attachment #248346 - Flags: review?(justdave) → review+
Checking in cvsmailfilter.pl; /cvsroot/CVSROOT/cvsmailfilter.pl,v <-- cvsmailfilter.pl new revision: 1.11; previous revision: 1.10 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Nelson: heads up on this just in case it causes any problems with stuff clearing the crypto-checkins list. I doubt it will, since the actual email address stayed the same, it was just the comment part of the From line that changed. Should be more readable on the newsgroup. :)
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: