Closed Bug 3212 Opened 26 years ago Closed 26 years ago

RX: nsXULAtoms.h

Categories

(Core :: XUL, defect, P2)

x86
Windows 95
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: chofmann, Assigned: danm.moz)

Details

I ignore constant or likely-to-be-initialized-once-at-startup data like atom pointers, but these scare me. Who owns XUL? I guess hyatt? Much of our non-static/global data needs to be partitioned by window, not reachable by other windows except through statics/globals. Therefore we're starting the hunt with statics and globals. Please have a look at the file(s) below to see if we can improve reentrantcy across the code base by making modifications to: layout/xul/content/src/nsXULAtoms.h: static PRInt32 nameSpaceID; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* button; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* checkbox; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* radio; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* text; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* toolbar; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* toolbox; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* tree; // The start of a tree view layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treecaption; // The caption of a tree view layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treehead; // The header of the tree view layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treebody; // The body of the tree view layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treeitem; // An item in the tree view layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treecell; // A cell in the tree view layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treechildren; // The children of an item in the tree viw layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treeindentation; // Specifies that the indentation for the level should occur here. layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treeallowevents; // Lets events be handled on the cell contents. layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treecol; // A column in the tree view layout/xul/content/src/nsXULAtoms.h: static nsIAtom* treecolgroup; // A column group in the tree view layout/xul/content/src/nsXULAtoms.h: static nsIAtom* progressmeter; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* mode; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* widget; layout/xul/content/src/nsXULAtoms.h: static nsIAtom* window;
Assignee: hyatt → danm
RX tasks aren't going to make M3. close the reentrantcy tracking tasks if this specific area has been looked at and doesn't seem to be a problem. Otherwise each of these areas still need some looking at.
Component: XP Miscellany → XUL
changing component to XUL
Status: NEW → ASSIGNED
The XUL atoms structure is static data in the truest sense of the word: its values should never change. Seems safe enough even in a threaded world.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
QA Contact: 3795
Updating QA Contact. danm, can y0u mark Verified now?
Status: RESOLVED → VERIFIED
Well, if you don't mind the resolution and verification being done by the same person, sure.
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL. XUL component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: danm.moz → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.