Closed Bug 32708 Opened 25 years ago Closed 25 years ago

Selection changed notifications get fired on every mouse move, even when selection does not change

Categories

(Core :: DOM: Selection, defect, P3)

All
Mac System 8.5
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: sfraser_bugs, Assigned: mjudge)

Details

(Keywords: perf)

We appear to be firing selection changed notifications on every mouse move, even when the actual selection has not changed. I think we might be collapsing/ reexpanding the selection to the same place. This is inefficient.
Perf.
Keywords: perf
Target Milestone: ---
M16 for now
Target Milestone: --- → M16
We also call NotifySelectionListeners() way too often. It's called from nsDOMSelection::Extend(), and from nsRangeList::TakeFocus(), which itself calls nsDOMSelection::Extend().
fixed
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
sfraser, is this fix to your satisfaction? I don't think this can be verified via black box means. Thanks!
Yes, I can tell this is fixed.
*SPAM*: Changing the QA contact of all open/resolved Selection bugs from elig@netscape.com to BlakeR1234@aol.com. After the many great years of service Eli has given to Mozilla, it's time for him to move on; he has accepted a position at Eazel. We'll be sad to see him go, and I'll do my best to fill his spot...
QA Contact: elig → BlakeR1234
You need to log in before you can comment on or make changes to this bug.