Closed
Bug 329796
Opened 19 years ago
Closed 19 years ago
Can't debug XForms on Mac OS X
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jhpedemonte, Assigned: jhpedemonte)
Details
(Keywords: fixed1.8.0.4, fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
benjamin
:
review+
benjamin
:
approval-branch-1.8.1+
dveditz
:
approval1.8.0.4+
|
Details | Diff | Splinter Review |
Bug 309210 made it so debug symbols are stripped from the xforms lib when packaging it in the XPI. However, it does the stripping for debug builds also, so I can't set breakpoints when trying to debug XForms.
Assignee | ||
Comment 1•19 years ago
|
||
Don't strip symbols if MOZ_DEBUG is defined.
Attachment #214445 -
Flags: review?(doronr)
Comment 2•19 years ago
|
||
Comment on attachment 214445 [details] [diff] [review]
patch
not really a build config bug, but a xforms bug :)
Attachment #214445 -
Flags: review?(doronr) → review+
Assignee | ||
Comment 3•19 years ago
|
||
Actually, I'm wondering if we shouldn't wrap the rule in rules.mk with "ifndef MOZ_DEBUG", since I don't really see a reason why we would want to strip if we are building debug. If not, this forces everyone who defines STRIP_XPI to also wrap it with the ifdef.
Comment 4•19 years ago
|
||
Same goes for Linux.
Assignee | ||
Comment 5•19 years ago
|
||
This should be fixed in rules.mk. It would be foolish to make all users add the MOZ_DEBUG check around STRIP_XPI.
Attachment #214445 -
Attachment is obsolete: true
Attachment #215294 -
Flags: review?(benjamin)
Updated•19 years ago
|
Attachment #215294 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 6•19 years ago
|
||
Checked in to trunk. ->FIXED
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•19 years ago
|
||
Comment on attachment 215294 [details] [diff] [review]
patch v2 - global change
Asking for approval for both branches. Without this patch, we cannot debug XForms XPI on Mac or Linux.
Attachment #215294 -
Flags: approval1.8.0.3?
Attachment #215294 -
Flags: approval-branch-1.8.1?(benjamin)
Updated•19 years ago
|
Attachment #215294 -
Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
Assignee | ||
Updated•19 years ago
|
Keywords: fixed1.8.1
Comment 8•19 years ago
|
||
Comment on attachment 215294 [details] [diff] [review]
patch v2 - global change
approved for 1.8.0 branch, a=dveditz for drivers
Attachment #215294 -
Flags: approval1.8.0.3? → approval1.8.0.3+
Comment 9•19 years ago
|
||
Code freeze for this release is Monday May 1, at which point approval will be withdrawn from this bug if it's not checked in.
Assignee | ||
Updated•19 years ago
|
Keywords: fixed1.8.0.4
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•