Closed
Bug 33079
Opened 25 years ago
Closed 24 years ago
messenger.css not used for msg pane body iframe
Categories
(SeaMonkey :: MailNews: Message Display, defect, P3)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
WONTFIX
People
(Reporter: BenB, Assigned: BenB)
Details
Style rules added to messenger.css are not used, when msgs are displayed, but
rules in mailheader.css are. Why?
mscott mentioned in bug #22960, that the loading of mailheader.css for every msg
might also be a perf problem. We could add the rules to messenger.css and would
be fine.
I also need a stylesheet, where I can add generic (not header-related) style
rules for msg display for other bugs, which I will add as dependencies. It might
also be of use for users, who want to change the layout of HTML msgs;
messenger.css is a much more obvious choice than mailheader.css for that.
Comment 1•25 years ago
|
||
I'll take this steve.
Ben, the style rules that are honored by the message pane header area are:
msgHdrViewOverlay.css
messenger.css
are you talking about the actual body iframe? You want that separate iframe to
inherit from messenger.css?
Assignee: selmer → mscott
Assignee | ||
Comment 2•25 years ago
|
||
wow, scott, that was fast. I wasn't even able to finish the report :-).
Adding dependencies. M16, because 31906 is M16.
> are you talking about the actual body iframe? You want that separate iframe to
> inherit from messenger.css?
Yes.
Assignee | ||
Updated•25 years ago
|
Target Milestone: --- → M16
Assignee | ||
Comment 4•24 years ago
|
||
OK, I take this as carte blanc for using mailheader.css for body rules :) (but
I'll propably rename it to message.css), because I need body rules for bug
31906.
No longer blocks: 16908
Assignee | ||
Comment 5•24 years ago
|
||
I'm using mailheader.css for 31906 now.
Isn't this still a skinnability bug (dunno for sure)?
No longer blocks: 31906
Ben, how is this going? mscott it seems ben is doing the work, and since you
never accepted the bug I'm asking ben to accept. If you really mind, feel free
to reassign and accept to yourself.
Ben, usually we leave dependencies forever unless they lose validity, this
allows people to see the status of related things. eg if bug 31906 is fixed I
would see it crossed out in the blocks list.
Assignee: mscott → mozilla
Assignee | ||
Comment 7•24 years ago
|
||
Adding skins keywords, as this is propably a skinnability bug.
mscott, what is the right way to fix this bug? Import messenger.css in
mailheader.css?
BTW: Adding rules for bug 31906 to mailheader.css was propably even the better
way for perf reasons.
timeless, that's the reason why I removed the dependancy. If bug 31906 really
depended on this bug, 31906 could not have been fixed.
Keywords: skins
Target Milestone: M18 → ---
Comment 8•24 years ago
|
||
If you import messenger.css then you are introducing a performance hit because
every time we display a message the iframe for the body gets reloaded. This is
expensive. Especially given all the rules in messenger.css.
I'm just not a proponent of doing this. Sorry guys.
We've got too many performance problems displaying messages, I'm leary of adding
more.
Assignee | ||
Comment 9•24 years ago
|
||
> every time we display a message the iframe for the body gets reloaded.
Don't we do that anyway? Why does an @import in a CSS file that is loaded anyway
(mailheader.css) cause an additional reload?
Anyway, I forgot that mailheader.css is part of the skin, so this isn't a
skinnability bug. So, this bug lost all (strong) justifications. WONTFIX.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WONTFIX
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•