I've got reports that xpcom doesn't compile on sparc linux. The problem is that the defines for xptcinvoke_sparc_solaris.cpp to tell if it's being compiled on sparc check for the defines for the solaris compiler, but not gcc. Here's the fix, as near as I can tell after talking with people building on solaris with both gcc and the native compiler and sparc linux with gcc. I don't have a platform to test it on, though. Index: xptcall/src/md/unix/xptcinvoke_sparc_solaris.cpp =================================================================== RCS file: /cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_sparc_solaris.cpp,v retrieving revision 1.7 diff -u -r1.7 xptcinvoke_sparc_solaris.cpp --- xptcinvoke_sparc_solaris.cpp 1999/11/06 03:39:08 1.7 +++ xptcinvoke_sparc_solaris.cpp 2000/03/24 18:20:53 @@ -24,7 +24,10 @@ #include "xptcprivate.h" -#ifndef sparc +/* solaris defines __sparc for workshop compilers and + linux defines __sparc__ */ + +#if !defined(__sparc) && !defined(__sparc__) #error "This code is for Sparc only" #endif

Oh, gcc on solaris also defines __sparc.

Adding rogerl@netscape.com and rich.burridge@Sun.COM to the cc list in case they want to get involved. See http://bugzilla.mozilla.org/show_bug.cgi?id=15604 for other issues on the Sparc Solaris xptcall code.

[richb - 4th April 2000] For what's its worth Chris, your fix works fine on the Solaris platform, with both gcc and Sun Workshop compilers. Check that puppy in!

Fix checked in.

Please ignore the spam. Changing address.

busted from my reassign

- Per last comments, age of bug, and no reopen - Marking Verified/Fixed. Please reopen if still a problem.