Closed Bug 33471 Opened 25 years ago Closed 25 years ago

Stop button doesn't interrupt download pop mail or news headers

Categories

(MailNews Core :: Backend, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: laurel, Assigned: sspitzer)

References

Details

(Keywords: regression)

Using 2000-03-27 commercial m15 builds, all platforms
This used to work, may be a result of fix for bug #30775?

Stop button no longer stops header downloading for newsgroups. 

1.  Open a newsgroup with several hundred new headers to download. 
2.  While headers are still being retrieved, click Stop button.

Result:  nothing happens, header retrieval keeps on going.  Try clicking Stop a
few times and it still doesn't stop.
Keywords: beta2, regression
QA Contact: lchiang → laurel
Blocks: 30775
accepting.  I can reproduce this.

But I don't think it is that other fix.

can you stop imap?  what about pop or smtp?


Status: NEW → ASSIGNED
I can stop imap, but not pop or nntp.

(I'd expect smtp, pop and nntp to act the same.)

does the beta1 build have this problem?  beta1 should have the fix for 30775.
actually, I think I can stop pop.

it just took a bit of trying.  I wonder if some clicks are getting dropped.
I was able to stop news downloading using beta1 on linux rh6.0 with one click.
Tried several different instances, several different groups.  Problem doesn't
happen in b1.

With current m15 build, repeated clicks don't help me with news. It's like the
energizer bunny.
I'm glad this is not happening on beta1.  the fix for 30775 is in beta1, so I
don't think that fix is causing this.

I may not be able to stop pop, I might have been seeing things.

I need to investigate more.
there are some troubling warnings in the build log, that may be causing this:

../../../dist/include/nsMsgProtocol.h:49: warning: 
`nsMsgProtocol::Cancel(nsresult)' was hidden
In file included from nsNNTPProtocol.cpp:36:
nsNNTPProtocol.h:166: warning:   by `nsNNTPProtocol::Cancel()'

I'm looking in to this now.
hmm.  that doesn't seem to be the problem.  the problem looks like the channel 
isn't in the load group, so when the user hits cancel, it isn't making its way 
into our channel.   

still need to investigate, but I've fixed that warning, so I'll check that in.
setting from blank to M15 milestone for these bugs affecting mail/news.  If you 
disagree, pls comment and add selmer@netscape.com to cc: list.
Target Milestone: --- → M15
this is pretty bad.  leaving m15.
updating summary.  stopping pop doesn't work either.

the problem is the channel is not in the load group, so it never gets the 
cancel.

I'm still working on why it's not in the load group, and how to get it in there.
Summary: Stop button doesn't interrupt download news headers. → Stop button doesn't interrupt download pop mail or news headers
Hey Seth, I think I know why this isn't working. in nsMsgWindow::StopUrls, we
are getting the root webshell and canceling that load group. The rootwebshell is
the webshell for the whole 3-pane.

I bet I'm running news and pop urls in the load group for the message pane which
is mMessageWindowWebShell.

an easy experiment you can try is to modify ::StopUrls to also cancel the load
group for mMessageWindowWebShell and see if that makes things all better.


I'll try that right now and report back.
mscott, no luck with that.  there are still zero channels 
in the load groups I get from mMessageWindowWebShell and mRootWebShell.

fixed.  thanks to mscott for the fix.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
OK using apr07 m15 commercial builds linux rh6.0, NT 4.0 and mac OS 9.0
Status: RESOLVED → VERIFIED
Keywords: nsbeta2
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.