Closed Bug 33579 Opened 25 years ago Closed 24 years ago

Content-Type "application/octet-stream" being shown inline

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

x86
Windows 2000
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: rhp)

Details

(Whiteboard: [nsbeta3+] [Fix in hand])

Attachments

(1 file)

The attached mail is being shown inline when it shouldn't. The Content-Type is application/octet-stream; which properly could give some kind of security problem.
Attached file mail being shown inline (deleted) —
Rich is the expert here.
Assignee: selmer → rhp
Well, the problem here is that the MIME service in Necko that tells us what kind of information is in a file is based on the file extension (a temp solution). In this example, the extension is TXT so the MIME service tells us we can render this. I'll have to look how this is overriding the content type...weird. - rhp
Status: NEW → ASSIGNED
Target Milestone: --- → M17
Mail Review hopes this is post-beta2, easy, polish work. Marking M18.
Target Milestone: M17 → M18
Keywords: correctness, nsbeta3
Ok, I have a fix for this one now. Its in my tree waiting approval. - rhp
Summary: Mail being shown inline → [FIXED] Mail being shown inline
Whiteboard: [FIXED]
per selmer and mail/news PDT
Whiteboard: [FIXED] → [FIXED] [nsbeta3+]
This should be fixed now. - rhp
Summary: [FIXED] Mail being shown inline → Mail being shown inline
Whiteboard: [FIXED] [nsbeta3+] → [nsbeta3+]
This should be fixed now. - rhp
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
henrik, can you verify this?
Doesn't work: A mail with: Content-Type: application/octet-stream; name="test.txt"; gets shown inline. HOWEVER a mail with: Content-Type: application/octet-stream; name="att:killer.sys"; or Content-Type: application/octet-stream; doesn't.... So it seems that the inline/not inline is still based on the filename of the attachment. "application/octet-stream" should never be shown inline....
Status: RESOLVED → REOPENED
Summary: Mail being shown inline → Content-Type "application/octet-stream" being shown inline
Status: REOPENED → ASSIGNED
Ok, I have this fixed in my tree. Will checkin today
Summary: Content-Type "application/octet-stream" being shown inline → [FIXED] Content-Type "application/octet-stream" being shown inline
Whiteboard: [nsbeta3+] → [nsbeta3+] [Fix in hand]
Should be all better now. - rhp
Status: ASSIGNED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Summary: [FIXED] Content-Type "application/octet-stream" being shown inline → Content-Type "application/octet-stream" being shown inline
Status: RESOLVED → VERIFIED
it's much better! Thanx rhp.... build 2000090608 on win2000
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: