Closed Bug 337964 Opened 19 years ago Closed 15 years ago

changing account during message composing doesn't apply signing prefs from new account.

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: piecu, Assigned: mkmelin)

References

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3 Build Identifier: version 1.5.0.2 (20060308) If you change an account during message composition (to the one with digital certificate assigned), you can send an email without giving the password. The Master Password dialog just not appearing. See details below. Reproducible: Always Steps to Reproduce: 1. Set an account with digital certificate and set a Master Password. Set another account without digital certificate. 2. Close Thunderbird. 3. Open Thunderbird. 4. In the Folders pane click an account without certificate. 5. Open a Compose window. 6. In the From: field change an account to the one with digital certificate. 7. Enter recipient, subject, body and send the e-mail. Actual Results: The e-mail is sent but the Master Password dialog didn't appear. Expected Results: The Master Password dialog should appear and the mail shouldn't be sent without giving the correct password.
One more thing that I've noticed. The message is sent but it is not digitally signed...
The password wasn't requested because thunderbird didn't try to sign it. The real bug appears to be that changing the "From" account didn't successfully pick up all of the new account settings, specifically the "always sign messages" setting. I haven't yet tried this specific case with a PKI certificate, but I do this all the time with Enigmail and PGP certs and always get my messages signed. In my case I use a second "identity" rather than a full "account" though.
Assignee: dveditz → mscott
Component: Security → Message Compose Window
QA Contact: thunderbird
Summary: The Master Password dialog does not appear when changing account during message composing → changing account during message composing doesn't apply signing prefs from new account.
QA Contact: message-compose
Reporter, does the issue still occur in the latest supported 2.0.0.x / Shredder trunk nightlies? (1.5.0.x is now end-of-life and the latest supported 2.0.0.x is 2.0.0.16)
Whiteboard: closeme 2008-08-28
I cannot verify this now because I'm on holiday :) I'll check it at the begining of September.
Whiteboard: closeme 2008-08-28 → closeme 2008-09-18
Assignee: mscott → nobody
(In reply to comment #3) > Reporter, does the issue still occur in the latest supported 2.0.0.x / Shredder > trunk nightlies? Yes, after changing to an account with message signing enabled, a massage was not signed. Tested on Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1a2pre) Gecko/2008072908 Shredder/3.0a2pre.
Keywords: qawanted
Whiteboard: closeme 2008-09-18
Reporter but also you use enigmail?
No, I'm not using enigmail.
Confirmed on linux, latest nightly. (We're talking S/MIME)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: qawanted
OS: Windows XP → All
Hardware: x86 → All
Assignee: nobody → mkmelin+mozilla
Attached patch proposed fix (deleted) — Splinter Review
I think this was in part intentional (as described in the code removal in this patch). What the patch does is that it follows the identity prefs. If the encryption/signing pref was changed for a message, and the identity is changed after that, we try to keep what the user set. If there's no cert set up for the identity we change to however, we will uncheck signing/encryption.
Attachment #405675 - Flags: ui-review?(clarkbw)
Attachment #405675 - Flags: review?(philringnalda)
Severity: major → normal
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 3.0rc1
Comment on attachment 405675 [details] [diff] [review] proposed fix This seems reasonable though I admit that I've never really used this before and am not very aware of the use cases.
Attachment #405675 - Flags: ui-review?(clarkbw) → ui-review+
Attachment #405675 - Flags: review?(philringnalda) → review+
Comment on attachment 405675 [details] [diff] [review] proposed fix Should be lowish risk as it's quite contained to affecting how signing is applied when changing identity - and that's not working as expected now.
Attachment #405675 - Flags: approval-thunderbird3?
Attachment #405675 - Flags: approval-thunderbird3? → approval-thunderbird3+
changeset: 4194:fbc2fe0f3fbf http://hg.mozilla.org/comm-central/rev/fbc2fe0f3fbf ->FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: TB2SM
No longer blocks: TB2SM
Depends on: 624440
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: