Closed Bug 33847 Opened 25 years ago Closed 25 years ago

IME doesn't work well on Editor

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED WORKSFORME

People

(Reporter: masaki.katakai, Assigned: mozeditor)

Details

Attachments

(1 file)

25452 is reproducible again on Windows build: 2000032909, also Linux platform. DEL key can not erase the last composing character. And on Linux platform, committed characters are inserted twice. I tested in Japanese locale. Problem 1: Both Windows and Linux 1) turn conversion on 2) type `a' 3) type DEL key -> `a' can not be erased Problem 2: Linux only 1) turn conversion on 2) type `a' 3) type Return -> two 'a' are inserted These problems happen on all input compoments that single line, multi line and HTML editor.
the 2nd problem reported in this bug has been fixed, assigning the other issue to ftang for initial review/debug
Assignee: beppe → ftang
Attached patch patches for editor/base (deleted) — Splinter Review
I found that JoeInsertTextImpl() returns when aStringToInsert.IsEmpty() is true. It's problem. We need to handle text=null at kInsertTextIME action to delete the composed text. I've attached the patch. Please review.
joe- is that your code ?
Assignee: ftang → jfrancis
Status: UNCONFIRMED → NEW
Ever confirmed: true
Yes, my code (though the "Joe" in the routine name was a temporary thing that is now gone). I had to rewrite the insert text path to minimize the number of layout & selection calls (for performance reasons), and I'm not surprised that I caused some IME problems. I did fix some problems with this after the 29th, so the patch is now stale. I'll have to investigate...
Status: NEW → ASSIGNED
Target Milestone: --- → M16
hmm, is this bug valid? DEL is for forward delete. In the scenario you describe, the insertion point is after the 'a'. Hitting DEL there shouldn't delete the 'a', right? It's a bit confusing to me because there is also the seperate IME selection stuff going on. If DEL is to do something different with ime than with non-ime, then we need to write some ime-specific deletion code. I'll have to get Frank's advice here.
DEL was wrong description, it should be BS. Sorry.
Ignore my comments about "Joe" being gone. Looks like I forgot to change the routine names. This bug is a WorksForMe. backspace behaves fine in mac and windows ime for me.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
verified in 4/6 build.
Status: RESOLVED → VERIFIED
*** Bug 34517 has been marked as a duplicate of this bug. ***
Did this get marked WORKSFORME for both (1) DEL key can not erase the last composing character. and (2)And on Linux platform, committed characters are inserted twice. Bug 34517 was dup'ed to this one, but has been reopened because (2) still occurs with 2000041109 linux commercial. Problem (2) still happens and makes composer unusable for Japanese. Should a new bug be opened for this. Maybe you want to open a new bug for (2)?
Severity: normal → blocker
Status: VERIFIED → REOPENED
Resolution: WORKSFORME → ---
Actually, instead of opening a new bug, we could just reassign bug 34517.
Yes, since 34517 was originally filed only for problem (2).
OK, I'll change this one back to WORKSFORME and reassign bug 34517 to jfrancis
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → WORKSFORME
verified in 4/12 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: