Closed
Bug 34205
Opened 25 years ago
Closed 22 years ago
Not compilable
Categories
(SeaMonkey :: General, defect, P3)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
INVALID
Future
People
(Reporter: BenB, Unassigned)
References
()
Details
(Keywords: helpwanted, regression)
I tried to compile extensions/pics on Linux, but it stopped with
nsPICS.cpp: In method `nsresult nsPICS::GetWebShell(unsigned int,
nsIWebShellServices *&)':
nsPICS.cpp:574: no matching function for call to
`nsIDocumentLoader::GetContentViewerContainer (PRUint32 &,
nsIContentViewerContainer **)'
../../../dist/include/nsIDocumentLoader.h:53: candidates are: nsresult
nsIDocumentLoader::GetContentViewerContainer(nsISupports *,
nsIContentViewerContainer **)
[...]
make[2]: *** [nsPICS.o] Error 1
ftang, you changed the interface (see the URL), which seems to be the reason for
the bustage, so I'm assigning to you and CCing neeti, who touched the breaking
line in nsPICS.cpp last.
Reporter | ||
Updated•25 years ago
|
Keywords: regression
Comment 1•25 years ago
|
||
We change that interface so we can be 64 bits clean. The origional code cast a
nsISupport* into a PRInt32 which break 64 bits machine. We didn't chagne the
nsPICS.cpp code because it is no longer build by default. Below is the code
which will make it build again. Please understand that this is still now 64-bits
clean and will be broken after harishd check in the changes in
htmlparser/src/nsIElementObserver.h
Index: pics/public/nsIPICS.h
===================================================================
RCS file: /m/pub/mozilla/extensions/pics/public/nsIPICS.h,v
retrieving revision 1.5
diff -c -r1.5 nsIPICS.h
*** nsIPICS.h 1999/11/29 21:07:43 1.5
--- nsIPICS.h 2000/04/03 17:28:42
***************
*** 42,48 ****
NS_DEFINE_STATIC_IID_ACCESSOR(NS_IPICS_IID)
NS_IMETHOD ProcessPICSLabel(char *label) = 0;
! NS_IMETHOD GetWebShell(PRUint32 key, nsIWebShellServices*& aResult) = 0;
NS_IMETHOD SetNotified(nsIWebShellServices* aResult, nsIURI* aURL, PRBool
notified) = 0;
};
--- 42,48 ----
NS_DEFINE_STATIC_IID_ACCESSOR(NS_IPICS_IID)
NS_IMETHOD ProcessPICSLabel(char *label) = 0;
! NS_IMETHOD GetWebShell(nsISupports* key, nsIWebShellServices*& aResult) = 0;
NS_IMETHOD SetNotified(nsIWebShellServices* aResult, nsIURI* aURL, PRBool
notified) = 0;
};
Index: pics/src/nsPICS.cpp
===================================================================
RCS file: /m/pub/mozilla/extensions/pics/src/nsPICS.cpp,v
retrieving revision 1.29
diff -c -r1.29 nsPICS.cpp
*** nsPICS.cpp 2000/03/11 01:17:00 1.29
--- nsPICS.cpp 2000/04/03 17:28:42
***************
*** 138,144 ****
NS_IMETHOD
ProcessPICSLabel(char *label);
! NS_IMETHOD GetWebShell(PRUint32 key, nsIWebShellServices*& aResult);
NS_IMETHOD SetNotified(nsIWebShellServices* aResult, nsIURI* aURL, PRBool
notified);
--- 138,144 ----
NS_IMETHOD
ProcessPICSLabel(char *label);
! NS_IMETHOD GetWebShell(nsISupports* key, nsIWebShellServices*& aResult);
NS_IMETHOD SetNotified(nsIWebShellServices* aResult, nsIURI* aURL, PRBool
notified);
***************
*** 567,573 ****
}
NS_IMETHODIMP
! nsPICS::GetWebShell(PRUint32 key, nsIWebShellServices*& aResult)
{
nsresult rv;
nsIContentViewerContainer* cont = nsnull;
--- 567,573 ----
}
NS_IMETHODIMP
! nsPICS::GetWebShell(nsISupports* key, nsIWebShellServices*& aResult)
{
nsresult rv;
nsIContentViewerContainer* cont = nsnull;
Index: pics/src/nsPICSElementObserver.cpp
===================================================================
RCS file: /m/pub/mozilla/extensions/pics/src/nsPICSElementObserver.cpp,v
retrieving revision 1.12
diff -c -r1.12 nsPICSElementObserver.cpp
*** nsPICSElementObserver.cpp 2000/01/11 20:47:46 1.12
--- nsPICSElementObserver.cpp 2000/04/03 17:28:42
***************
*** 130,139 ****
{
return Notify(aDocumentID, numOfAttributes, nameArray, valueArray);
}
! NS_IMETHODIMP nsPICSElementObserver::Notify(PRUint32 aDocumentID,
PRUint32 numOfAttributes, const PRUnichar* nameArray[],
const PRUnichar* valueArray[])
{
nsresult rv;
int status;
nsIWebShellServices* ws;
--- 130,140 ----
{
return Notify(aDocumentID, numOfAttributes, nameArray, valueArray);
}
! NS_IMETHODIMP nsPICSElementObserver::Notify(PRUint32 key,
PRUint32 numOfAttributes, const PRUnichar* nameArray[],
const PRUnichar* valueArray[])
{
+ nsISupports* aDocumentID = (nsISupports*) key; // remove bad-for-64bits cast
later.
nsresult rv;
int status;
nsIWebShellServices* ws;
Reassign this back to mozilla@bucksch.org and add harishd / dp to the cc list.
mozilla@bucksch.org- are you the new PICS owner now ?
Assignee: ftang → mozilla
Reporter | ||
Comment 2•25 years ago
|
||
> mozilla@bucksch.org- are you the new PICS owner now ?
No, why? Because I'm trying to compile it? :-) I compiled it only "accidently"
and reported the bug I found. REASSIGNing to owner.
From <http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser>:
> As of M14, Seamonkey is not expected to include PICS support, and the code has
> been removed from the Mozilla tree.
If this is not supposed to compile, maybe it should actually be removed from
SeaMonkeyAll?
Assignee: mozilla → neeti
Comment 3•25 years ago
|
||
changing qa contact on selected bugs from paulmac to elig@netscape.com
QA Contact: paulmac → elig
helpwanted
Updated•24 years ago
|
QA Contact: elig → neeti
Comment 5•24 years ago
|
||
Offering help in getting PICS working in Mozilla
Updated•22 years ago
|
Component: PICS → Browser-General
Comment 6•22 years ago
|
||
Is this not fixed ?
Comment 7•22 years ago
|
||
PICS has been dropped from Mozilla. Presumably this should be WONTFIX or something.
Comment 8•22 years ago
|
||
Thanks Matthew, marking as Invalid
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → INVALID
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•