Closed
Bug 343713
Opened 18 years ago
Closed 18 years ago
JS_ASSERT(JSVAL_TO_OBJECT(v) == OBJ_GET_PARENT(cx, thisp));
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha1
People
(Reporter: bc, Assigned: mrbkap)
References
()
Details
(Keywords: regression, verified1.8.0.7, verified1.8.1)
Attachments
(2 files)
(deleted),
patch
|
brendan
:
review+
dveditz
:
approval1.8.0.7+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
trunk and 1.8.0.5 winxp, prolly 1.8 as well.
Reporter | ||
Updated•18 years ago
|
Assignee: general → mrbkap
Reporter | ||
Updated•18 years ago
|
Flags: blocking1.8.1?
Flags: blocking1.8.0.6?
Reporter | ||
Comment 1•18 years ago
|
||
Checking in regress-343713.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-343713.js,v <-- regress-343713.js
initial revision: 1.1
Flags: in-testsuite+
Comment 2•18 years ago
|
||
I think the patch for bug 336601 introduced this regression. It obviously introduced the botching assertion.
/be
Assignee | ||
Comment 3•18 years ago
|
||
Attachment #228260 -
Flags: review?(brendan)
Comment 4•18 years ago
|
||
mrbkap: but why? Is not that assertion trying to uphold an invariant we believe never varies? Or were we smoking something?
/be
Comment 5•18 years ago
|
||
Comment on attachment 228260 [details] [diff] [review]
Kill it
Argh, |with|.
/be
Attachment #228260 -
Flags: review?(brendan) → review+
Assignee | ||
Comment 6•18 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Updated•18 years ago
|
Keywords: regression
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
Reporter | ||
Comment 9•18 years ago
|
||
verified fixed 1.8.1 windows/macppc/linux 20060707
Keywords: fixed1.8.1 → verified1.8.1
Comment 10•18 years ago
|
||
regression fix needed for 1.0.9+
Comment 11•18 years ago
|
||
Comment on attachment 228260 [details] [diff] [review]
Kill it
approved for 1.8.0 branch, a=dveditz for drivers
Attachment #228260 -
Flags: approval1.8.0.7+
Updated•18 years ago
|
Flags: blocking1.8.0.7? → blocking1.8.0.7+
Reporter | ||
Comment 13•18 years ago
|
||
verified fixed 1.8.0.7 20060818 windows/mac*/linux
Keywords: fixed1.8.0.7 → verified1.8.0.7
You need to log in
before you can comment on or make changes to this bug.
Description
•