Closed Bug 343713 Opened 18 years ago Closed 18 years ago

JS_ASSERT(JSVAL_TO_OBJECT(v) == OBJ_GET_PARENT(cx, thisp));

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9alpha1

People

(Reporter: bc, Assigned: mrbkap)

References

()

Details

(Keywords: regression, verified1.8.0.7, verified1.8.1)

Attachments

(2 files)

trunk and 1.8.0.5 winxp, prolly 1.8 as well.
Assignee: general → mrbkap
Blocks: 336601
Flags: blocking1.8.1?
Flags: blocking1.8.0.6?
Checking in regress-343713.js; /cvsroot/mozilla/js/tests/js1_5/Regress/regress-343713.js,v <-- regress-343713.js initial revision: 1.1
Flags: in-testsuite+
No longer blocks: 336601
I think the patch for bug 336601 introduced this regression. It obviously introduced the botching assertion. /be
Attached patch Kill it (deleted) — Splinter Review
Attachment #228260 - Flags: review?(brendan)
mrbkap: but why? Is not that assertion trying to uphold an invariant we believe never varies? Or were we smoking something? /be
Comment on attachment 228260 [details] [diff] [review] Kill it Argh, |with|. /be
Attachment #228260 - Flags: review?(brendan) → review+
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Keywords: regression
Blocks: 336601
verified fixed 1.9a1 2006070603
Status: RESOLVED → VERIFIED
Flags: blocking1.8.1? → blocking1.8.1+
This fix landed as part of js1.7. /be
Keywords: fixed1.8.1
verified fixed 1.8.1 windows/macppc/linux 20060707
Attached patch 1.0.x branch patch (deleted) — Splinter Review
regression fix needed for 1.0.9+
Comment on attachment 228260 [details] [diff] [review] Kill it approved for 1.8.0 branch, a=dveditz for drivers
Attachment #228260 - Flags: approval1.8.0.7+
Flags: blocking1.8.0.7? → blocking1.8.0.7+
Fixed on the 1.8.0 branch.
Keywords: fixed1.8.0.7
verified fixed 1.8.0.7 20060818 windows/mac*/linux
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: