Closed Bug 35161 Opened 25 years ago Closed 24 years ago

Choosing "Save Page As" to a read-only destination crashes

Categories

(Core Graveyard :: File Handling, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.8

People

(Reporter: mcovarru, Assigned: law)

References

Details

(Whiteboard: [nsbeta3-][PDTP2][rtm-]Fix in hand, reviewed and approved)

Attachments

(2 files)

From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.5-15 i586; en-US; m14) BuildID: 2000040616 Trying to save a file to a directory where I don't have permissions produces a succession of Alert boxes saying "Unknown error". After about three of these Alerts, Mozilla crashes. Reproducible: Always Steps to Reproduce: 1.Try to download a file to a directory without write permissions 2. 3. Actual Results: Three uninformative Alerts went up and Mozilla crashed. Expected Results: Put up an informative Alert and put up the file chooser dialog again for the user to select a writable place to put the file.
this is a variant of bug 27609 but the crash is new. (27609 was a leftover from bug 23821 where mozilla actually was hanging. Marked fixed 2000-02-10)
-> networking
Assignee: asadotzler → gagan
Status: UNCONFIRMED → NEW
Component: Browser-General → Networking
Ever confirmed: true
QA Contact: jelwell → tever
->law
Assignee: gagan → law
*** Bug 36534 has been marked as a duplicate of this bug. ***
Adding crash keyword.
Keywords: crash
Target Milestone: --- → M18
Move to M21 target milestone.
Target Milestone: M18 → M21
Upping to M18; this is bad and should be relatively easy to remedy.
Status: NEW → ASSIGNED
Target Milestone: M21 → M18
*** Bug 45629 has been marked as a duplicate of this bug. ***
*** Bug 47751 has been marked as a duplicate of this bug. ***
*** Bug 47071 has been marked as a duplicate of this bug. ***
Nav triage team: Changing summary to something we understand; [nsbeta3+]
Summary: fdirectory permissions on save causing crash → Choosing "Save Page As" to a read-only destination crashes
Whiteboard: [nsbeta3+]
Marking P1.
Priority: P3 → P1
PDT downgrading to P2 and putting [PDTP2] in status whiteboard
Priority: P1 → P2
Whiteboard: [nsbeta3+] → [nsbeta3+][PDTP2]
Blocks: 50326
I have two minor patches which avoid the crash. Waiting for Warren to OK the buffered streams one. Index: nsStreamXferOp.cpp =================================================================== RCS file: /cvsroot/mozilla/xpfe/components/xfer/src/nsStreamXferOp.cpp,v retrieving revision 1.32 diff -w -r1.32 nsStreamXferOp.cpp 330a331 > break; 333a335 > break; Index: base/src/nsBufferedStreams.cpp > =================================================================== > RCS file: /cvsroot/mozilla/netwerk/base/src/nsBufferedStreams.cpp,v > retrieving revision 1.8 > diff -r1.8 nsBufferedStreams.cpp > 335a336,339 > > if (!mStream) { > > // Stream already cancelled/flushed; probably because of error. > > return NS_OK; > > }
*** Bug 49919 has been marked as a duplicate of this bug. ***
Move to RTM.
Keywords: rtm
Whiteboard: [nsbeta3+][PDTP2] → [nsbeta3-][PDTP2][rtm+]
Adding patch keyword.
Keywords: patch
PDT marking [rtm need info] since no code reviews are listed.
Whiteboard: [nsbeta3-][PDTP2][rtm+] → [nsbeta3-][PDTP2][rtm need info]
Fix in hand.
Whiteboard: [nsbeta3-][PDTP2][rtm need info] → [nsbeta3-][PDTP2][rtm need info]Fix in hand
*** Bug 50697 has been marked as a duplicate of this bug. ***
r=mcafee I'm deeming myself module owner for the xfer stuff, and I approve it. Going to mscott for super-review (he knows this stuff).
*** Bug 48620 has been marked as a duplicate of this bug. ***
Hey Bill, your patch looks great to me. I assume the changes to getString that you made fix the exception errors that get thrown every now and then? Also, I take it you have approval from I10N for the localization changes? Assuming that's cool... sr=mscott
Yes, getString was barfing when fetching "unknownTime" and I fixed that as well. You are right about the l10n clearance on the new strings. We're working on it. Thanks.
Adding cc to L10n folks ...
You can assume now that it's cool with L10n :-) Approved.
Adding myself to cc: list.
r=mcafee and sr=mscott PDT, please approve.
Whiteboard: [nsbeta3-][PDTP2][rtm need info]Fix in hand → [nsbeta3-][PDTP2][rtm+]Fix in hand, reviewed and approved
rtm-, this is much bigger than a breadbasket. Is there a very very small fix that makes the crash go away?
Whiteboard: [nsbeta3-][PDTP2][rtm+]Fix in hand, reviewed and approved → [nsbeta3-][PDTP2][rtm-]Fix in hand, reviewed and approved
Yes. The simple patch to nsBufferedStream.cpp (posted to description a long time ago) will stop the crash 99.9% of the time. The additional "break" statements to nsStreamXferOp.cpp will stop the crash in the other .1% of the time. The message box would still suck, though.
on my linux debug branch build of today when I try to save a file to /junk.hmtl it pops up a dialog saying "Unknown error [3 80004005]". I note the "Saving File" dialog shows the saving "To:" as "//unk.html" which is missing the leading "j".
Gotta fix this one. I have the patch but it doesn't work any more :-(. Should be relatively easy to get it back in gear.
Keywords: crash, patch, rtmnsbeta1
Target Milestone: M18 → mozilla0.8
Setting target milestone.
*** Bug 64924 has been marked as a duplicate of this bug. ***
Attached file test (deleted) —
This has been fixed. There is still a problem handling this error in many cases, though; see bug 67216.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
QA Contact: tever → benc
Component: Networking → File Handling
QA Contact: benc → petersen
Verified on the linux 2003-01-23-05 trunk.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: