Closed
Bug 3517
Opened 26 years ago
Closed 26 years ago
Table crash on border collapse style being set
Categories
(Core :: Layout: Tables, defect, P2)
Tracking
()
VERIFIED
FIXED
M9
People
(Reporter: hyatt, Assigned: karnaze)
References
()
Details
Attachments
(1 file)
(deleted),
text/html
|
Details |
Edit the css file that accompanies sidebar.xul. If you
apply a border collapse style to the tree, you have
a crash in the table code when you try to open a tree
item.
Double click on an item to open it and reproduce the crash
(after you've edited the CSS file to add in the collapse
rule for the tree).
It appears that the arrays of border edges are out of sync
when a new row gets inserted into the tree (ContentInserted
notification that triggers a reflow).
At the moment, no tree view can have a border collapse style
because of this bug.
Updated•26 years ago
|
Severity: normal → critical
I think I have the fix for this bug, but bug 11393 is preventing me from
verifying. I will check in my trivial change, which is shown below. Chris,
after 11393 is fixed, can you please verify with the attached test case?
void nsTableFrame::SetBorderEdgeLength(PRUint8 aSide,
PRInt32 aIndex, nscoord aLength)
{
nsBorderEdge *border = (nsBorderEdge*)
(mBorderEdges.mEdges[aSide].ElementAt(aIndex));
if (border)
border->mLength = aLength;
}
plus 2 asserts removed, one each from
nsTableFrame::ComputeVerticalCollapsingBorders and
nsTableFrame::ComputeHorizontalCollapsingBorders:
NS_ASSERTION(PR_FALSE, "aStartRowIndex>=rowCount in
ComputeVerticalCollapsingBorders");
Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•26 years ago
|
||
More was needed than described 8/6 comments.
Assignee | ||
Comment 9•26 years ago
|
||
I forgot to mention that it was fixed using Steve's attachment. I could not find
sidebar.xul as mentioned in the original comments.
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 10•26 years ago
|
||
Using 8/16 Apprunner on Win 95, Win 98 and Win NT, and Steve's test case from
8/6, verified bug fixed. No crashes.
You need to log in
before you can comment on or make changes to this bug.
Description
•