Closed Bug 35383 Opened 25 years ago Closed 24 years ago

[MLK] nsMenuBar.cpp leaks nsStringBundle objects

Categories

(Core :: XUL, defect, P1)

Product:
Core
Component:
XUL
Platform:
PowerPC
Mac System 9.x
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: beard, Assigned: saari)

References

(
URL
)

Details

(Keywords: memory-leak)

See CVS blame URL above, you aren't releasing the bundle variable.
This code really should just use nsCOMPtr and NS_WITH_SERVICE .....
D'oh, I'm on it
Status: NEW → ASSIGNED
Target Milestone: --- → M16
Priority: P3 → P1
Keywords: mlk
looks like a one-time leak adding the Apple menu, right? moving to m18. If this is bigger than I realize, lets nominate for nsbeta2
Target Milestone: M16 → M18
mass-moving all bugs to m21 that are not dofood+, or nsbeta2+
Target Milestone: M18 → M21
Just found this one again looking through http://ftp.mozilla.org/pub/bloat-reports/2000-06-16-pda.tucows.com-palm-prod_sch ed.html-leaks.html.gz#0x045A26D8 It looks like it's holding on to a good bit of stuff, and it's trivial to fix. In fact, I'll attach a patch that should fix the leak, but I can't test it.
Actually, Simon fixed this since waterson's log was generated. That's what I get for using "&rev=1.37" to get the right line number, and then reading the old code... Marking fixed. cc:ing sfraser
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
verified fixed per dbaron. Thanks.
Status: RESOLVED → VERIFIED
OS: Mac System 9.x
You need to log in before you can comment on or make changes to this bug.