Closed Bug 3552 Opened 26 years ago Closed 26 years ago

named entities that start with X or x don't work

Categories

(Core :: DOM: HTML Parser, defect, P3)

All
Other
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: erik, Assigned: rickg)

References

()

Details

Named entities such as Ξ and ξ don't work, probably because of confusion with numeric entities such as ÿ
Here is the fix for it (two files). I have already send to rickg to review but have not get his approval. Rick, do you want to check them in ? Index: nsHTMLTokens.cpp =================================================================== RCS file: /m/pub/mozilla/htmlparser/src/nsHTMLTokens.cpp,v retrieving revision 3.76 diff -c -r3.76 nsHTMLTokens.cpp *** nsHTMLTokens.cpp 1999/03/08 17:42:54 3.76 --- nsHTMLTokens.cpp 1999/03/10 19:30:00 *************** *** 1381,1388 **** } #endif aString.Append(PRUnichar(value)); ! }//if ! return value; }//if }//if --- 1381,1388 ---- } #endif aString.Append(PRUnichar(value)); ! return value; ! }//if }//if }//if Index: nsString.cpp =================================================================== RCS file: /m/pub/mozilla/base/src/nsString.cpp,v retrieving revision 3.49 diff -c -r3.49 nsString.cpp *** nsString.cpp 1999/03/07 19:22:38 3.49 --- nsString.cpp 1999/03/10 19:22:22 *************** *** 750,755 **** --- 750,761 ---- cp--; } + if(cp < mStr) + { + *aErrorCode=NS_ERROR_ILLEGAL_VALUE; + result=0; + return result; + } //now iterate the numeric chars and build our result while(cp>=mStr) { theChar=*cp--;
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Fixed (I believe). However, certain entities don't draw correctly; to wit: &and; actually shows up as a square, even though I'm returning the right unicode value.
I pulled a fresh tree and &Xi; and &xi; are indeed fixed. Those other entities such as &and; are not displayed properly because I haven't checked in the Unicode support for Windows GFX yet. That's a separate bug. I'd be happy to mark this VERIFIED if the QA representative agrees.
QA Contact: 3847 → 4141
Attempting to steal gem's HTMLParser bugs all at once. Changing QAContact to janc.
Status: RESOLVED → VERIFIED
Fixed in the 6/17 Build (1999061708).
You need to log in before you can comment on or make changes to this bug.