I got a null pointer crash in: nsImapMailFolder::CreateMessageFromMsgDBHdr(nsImapMailFolder * const 0x028cf7ac, nsIMsgDBHdr * 0x00000000, nsIMessage * * 0x0012fa88) line 1969 + 7 bytes nsMsgMessageDataSource::GetThreadsFirstMessage(nsIMsgThread * 0x0640d440, nsIMsgFolder * 0x028cf7ac, nsIMessage * * 0x0012fa88) line 1453 + 28 bytes nsMsgMessageDataSource::OnChangeUnreadMessageCount(nsIMessage * 0x06677c94) line 856 + 50 bytes nsMsgMessageDataSource::OnChangeStatus(nsIRDFResource * 0x06677c80, unsigned int 8, unsigned int 9) line 788 nsMsgMessageDataSource::OnItemPropertyFlagChanged(nsMsgMessageDataSource * const 0x04cd0730, nsISupports * 0x06677c80, nsIAtom * 0x028cd380, unsigned int 8, unsigned int 9) line 743 nsMsgMailSession::OnItemPropertyFlagChanged(nsMsgMailSession * const 0x04c76314, nsISupports * 0x06677c80, nsIAtom * 0x028cd380, unsigned int 8, unsigned int 9) line 196 nsMsgFolder::NotifyPropertyFlagChanged(nsMsgFolder * const 0x028cf7ac, nsISupports * 0x06677c80, nsIAtom * 0x028cd380, unsigned int 8, unsigned int 9) line 2189 nsMsgDBFolder::SendFlagNotifications(nsISupports * 0x06677c80, unsigned int 8, unsigned int 9) line 432 + 35 bytes nsMsgDBFolder::OnKeyChange(nsMsgDBFolder * const 0x028cf818, unsigned int 337118, unsigned int 8, unsigned int 9, nsIDBChangeListener * 0x00000000) line 583 nsMsgDatabase::NotifyKeyChangeAll(nsMsgDatabase * const 0x04ebc120, unsigned int 337118, unsigned int 8, unsigned int 9, nsIDBChangeListener * 0x00000000) line 272 + 28 bytes nsMsgDatabase::MarkHdrReadInDB(nsMsgDatabase * const 0x04ebc120, nsIMsgDBHdr * 0x06675350, int 1, nsIDBChangeListener * 0x00000000) line 1370 nsMsgDatabase::MarkHdrRead(nsMsgDatabase * const 0x04ebc120, nsIMsgDBHdr * 0x06675350, int 1, nsIDBChangeListener * 0x00000000) line 1640 + 27 bytes nsMsgDatabase::MarkRead(nsMsgDatabase * const 0x04ebc120, unsigned int 337118, int 1, nsIDBChangeListener * 0x00000000) line 1382 + 29 bytes nsMsgHdr::MarkRead(nsMsgHdr * const 0x06675350, int 1) line 230 + 31 bytes nsImapMailFolder::NormalEndMsgWriteStream(nsImapMailFolder * const 0x028cf848, unsigned int 337118) line 2717 XPTC_InvokeByIndex(nsISupports * 0x028cf848, unsigned int 5, unsigned int 1, nsXPTCVariant * 0x06404030) line 139 EventHandler(PLEvent * 0x06404070) line 478 + 41 bytes PL_HandleEvent(PLEvent * 0x06404070) line 563 + 10 bytes PL_ProcessPendingEvents(PLEventQueue * 0x010f0750) line 508 + 9 bytes _md_EventReceiverProc(HWND__ * 0x0fc90290, unsigned int 49435, unsigned int 0, long 17762128) line 1018 + 9 bytes USER32! 77e71820() 010f0750() not sure how to reproduce it. but I've got a patch, that prevents the crash and gives us an assertion. will attach in a second.

marking m16, p1. I plan on checking this in tonight.

fixed. to qa: not sure how to reproduce, so verifying will be tough. maybe if this stack trace matches something in talkback... I added some assertions, so if someone gets into the state, they can come back here and added info.

Adding crash keyword

I just hit an assertion: nsMessagedatasource.cpp line 1620 NS_ASSERTION(firstHdr,"firstHdr is null. can you reproduce this? add info to bug #35567"); I am not sure wether I can reproduce it but I hit the place so it is not fixed. I reopen the bug. I made a test saving a email to the draft folder, than I removed that email from the draft folder. I wrote another email with one to addresses , two cc and one bcc. I saved the email via save as to the draft folder and got the assert. I saved the file a second time and got nothing.

I just looked on my comment and was dissapointed about the quality: Win98 debug build cvs 20000601.

moving to p2, m18 until I can reproduce it. cleaning up summary.

I just hit the assert telling me to add info to this bug. WinNT commercial build from 7/6. I selected all the mail in my inbox (50 items) and hit the delete button. When the last one went away the assert came up.

I believe this is fixed - I haven't seen it in a long time. There was a problem with handling "empty threads" that received a new message, i.e., you delete the last message in a thread, shut down, startup, and then receive a message that belongs in the same thread - that would cause this assert. I fixed that.

marking fixed. please reopen if you see it again.

I tried to reproduce this on a current debug Windows 2000 build, but couldn't. verified fixed.