Using Mar 10 build on Mac 8.5 1) Select Change Icons menu item 2) Apprunner app crashes. 3) No restart necessary, just Relaunch of app. beppe, can you assign a QA Contact to check Win32 and Linux please.

Setting to M3 radar.

Re-assigned to law@netscape.com and changed platform and OS to All. Bill, this looks almost identical to bug #3468, "apprunner crashes on File|Print." Do you know what this "Change Icons" command is supposed to do or who added it?

Changed component to XPApps.

Changed component to XPApps.

Re-assigned to matt@netscape.com. Matt, this doesn't need to work yet, it just needs to not crash.

here is the call stack Looks like it is appcore nsBaseAppCore::FindNamedDOMNode(const nsString & {...}, nsIDOMNode * 0x00000000, int & 0, int 1) line 147 + 27 bytes nsBrowserAppCore::SetButtonImage(nsIDOMNode * 0x00f158e0, int 1, const nsString & {...}) line 374 + 48 bytes nsBrowserAppCore::PrintPreview(nsBrowserAppCore * const 0x00fda140) line 414 + 40 bytes BrowserAppCorePrintPreview(JSContext * 0x00ea16f0, JSObject * 0x018ae0d8, unsigned int 0, long * 0x018b6e00, long * 0x0012eb84) line 412 + 12 bytes js_Invoke(JSContext * 0x00ea16f0, unsigned int 0, int 0) line 650 + 26 bytes js_Interpret(JSContext * 0x00ea16f0, long * 0x0012f35c) line 2183 + 15 bytes js_Invoke(JSContext * 0x00ea16f0, unsigned int 0, int 0) line 666 + 13 bytes js_Interpret(JSContext * 0x00ea16f0, long * 0x0012fad4) line 2183 + 15 bytes js_Execute(JSContext * 0x00ea16f0, JSObject * 0x01896fd8, JSScript * 0x00f993e0, JSFunction * 0x00000000, JSStackFrame * 0x00000000, int 0, long * 0x0012fad4) line 815 + 13 bytes JS_EvaluateUCScriptForPrincipals(JSContext * 0x00ea16f0, JSObject * 0x01896fd8, JSPrincipals * 0x00000000, unsigned short * 0x00fae690, unsigned int 22, char * 0x012daf30, unsigned int 0, long * 0x0012fad4) line 2324 + 27 bytes nsJSContext::EvaluateString(nsJSContext * const 0x00ea16b0, const nsString & {...}, char * 0x012daf30, unsigned int 0, nsString & {...}, int * 0x0012fb10) line 96 + 64 bytes nsXULCommand::ExecuteJavaScriptString(nsXULCommand * const 0x00fae530, nsIWebShell * 0x00e62640, nsString & {...}) line 179 nsXULCommand::DoCommand(nsXULCommand * const 0x00fae530) line 140 + 31 bytes nsXULCommand::MenuSelected(const nsMenuEvent & {...}) line 193 nsMenuItem::MenuSelected(const nsMenuEvent & {...}) line 305 nsWindow::ProcessMessage(unsigned int 273, unsigned int 4, long 0, long * 0x0012fe64) line 1658 nsWindow::WindowProc(void * 0x05c307d2, unsigned int 273, unsigned int 4, long 0) line 450 + 27 bytes USER32! 77e71250() nsCOMPtr<nsIDOMNode> nsBaseAppCore::FindNamedDOMNode(const nsString &aName, nsIDOMNode * aParent, PRInt32 & aCount, PRInt32 aEndCount) { nsCOMPtr<nsIDOMNode> node; aParent->GetFirstChild(getter_AddRefs(node)); while (node) { nsString name; node->GetNodeName(name); //printf("FindNamedDOMNode[%s] %d == %d\n", name.ToNewCString(), aCount, aEndCount); if (name.Equals(aName)) { aCount++; if (aCount == aEndCount) return node; }

beppe, please set QA Contact. Thanks!

Ok... I've removed the Change Icons menu item. This was an experimental menu item that rods added to dynamically change the icons in the main toolbar. Unfortunately, this code was written when the toolbars consisted of "buttons" now the toolbars are a collection of "titledbuttons" so the app core code crashes :-( The browser appcore function called BrowserPrintPreview() should be changed to actually bring up a print preview window, not try to change the toolbar icons... -- rick

*** Bug 3668 has been marked as a duplicate of this bug. ***

setting QA contact to Christopher

Resolved as FIXED.

Marking Verified with Mar 13 build.