Closed Bug 36221 Opened 25 years ago Closed 25 years ago

Throbber never stops when loading a frameset doc

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

All
Mac System 8.5
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: sfraser_bugs, Assigned: mscott)

References

()

Details

When loading the frameset document in the URL, the throbber never stops.
mscott, it doesn't look like the nsIWebProgressListener::OnStatusChange (flag_net_stop) is being called in this case.
Assignee: travis → mscott
Travis, that's because it's a child doc loader that finishes the load so the stop is coming back via a OnChildStatusChange instead of a onStatusChange. Maybe that's bogus on my part and I should always call onStatusChange...
Fixed. I always call OnStatusChange for starting and stopping a document instead of using the onChildStatusChange even if a child was the one who signaled the on stop document load.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Target Milestone: --- → M16
Yeah, the point is you should be able to watch just OnStatusChange and you will only be told when the top level doc starts and stops as well as the transition points for the top document in the middle. If you don't care about the actual status of individual frames loading then you can ignore OnChildStatusChange. So basically in a frame world you should get.. OnStatusChange(flag_net_start) OnStatusChange(flag_net_dns) OnStatusChange(flag_net_connecting) OnStatusChange(flag_net_negotiating) Possibly...OnStatusChange(flag_net_redirecting) OnStatusChange(flag_net_transferring) OnChildStatusChange(flag_net_start) [frame 1] ... Other dns, connecting etc for the given frame OnChildStatusChange(flag_net_stop) OnChildStatusChange(flag_net_start) [frame 2] ... Other dns, connecting etc for the given frame OnChildStatusChange(flag_net_stop) OnStatusChange(flag_net_stop) Obviously the child status messages may intermix, but basically it's an encapsulation of starts and stops.
Oh, looks like you already fixed it. :)
Fixed in the May 22nd build.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
Component: Layout: HTML Frames → Layout: Images
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.