Closed Bug 36686 Opened 25 years ago Closed 25 years ago

nsMsgValidityManager is incomplete

Categories

(MailNews Core :: Backend, defect, P3)

x86
BeOS
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cls, Assigned: Bienvenu)

Details

The BeOS build is breaking because the nsMsgValidityManager class appears to be missing the implementation for the NewTable() method. Best I can tell, this bustage isn't seen on the tinderboxes because linux doesn't require all symbols to be resolved at link time.
I've checked in a dummy implementation of nsMsgSearchValidityManager::NewTable into mailnews/base/search/src/nsMsgSearchNews.cpp so that the beos porters will not be hung up on this build issue all day.
sorry 'bout that. the validity manager isn't instantiated, so I think other compilers don't need the symbols to be resolved. I can mark this fixed, right? I don't want to leave a fake blocker open. Please reopen if it's not fixed.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
The dummy NewTable() is inside a XP_BEOS ifdef at the moment but I can see other platforms running into this problem eventually. The symbol resolution is a link-time issue, not a runtime one. I believe HPUX, AIX, QNX, & OpenVMS each require the symbols to be resolved at link time. (The HPUX tinderboxes are orange but the log says that they are failing on a compiler error before they hit this problem.) Since the class isn't instantiated, can we just remove the XP_BEOS ifdef or do you have a real implementation that you can check in?
Severity: blocker → critical
I'm working on a real implementation, but I won't be able to check it in until the tree opens, and if the tree doesn't open until late this afternoon, it'll have to wait for this weekend.
This shows up under Tru64 too
Keywords: verifyme
bienvenu, did you get that nsMsgSearchValidityManager::NewTable implementation checked in? jim_nance, can you confirm whether this bug is in fact fixed?
yes, I did check it in, a very long time ago.
verified.
Status: RESOLVED → VERIFIED
QA Contact: lchiang → stephend
Product: MailNews → Core
Product: Core → MailNews Core
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.