Closed Bug 3742 Opened 26 years ago Closed 26 years ago

can't hit enter then backspace

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: buster, Assigned: buster)

Details

edit a doc put your caret between two characters hit Enter, inserting a BR hit Backspace. this should remove the BR it doesn't. It has no effect. :(
Status: NEW → ASSIGNED
Summary: can't hit enter then backspace → can't hit enter then backspace
Target Milestone: M3
I have the fix for this. It is safe code with very little change of introducing any instability. It can be checked in as soon as I get approval. Greg, will you work with the release team to decide if this is in or out for M3?
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
fixed, with approval from chofmann and gkostello. DeleteSelection wasn't dealing with edge conditions well (there were placeholders in the code, but they needed to be filled in.) Also, it turns out that we needed to join consecutive text nodes (<text1><BR><text2> becomes <text1><text2> after the <BR> is deleted; this then is collapsed to <text1text2>.)
Steve, I'm verifying this one. about to mark Verified-FIXED. The only thing is that after hitting Enter, you have to click on the line above and then hit backspace which removes the BR.. you meant that right?
sorry, I don't understand your last comment. Let's start with this docuemnt: <body>12</body> so the document is "12". Put your caret between '1' and '2': "1^2" Hit ENTER "1 2" Your selection is now the <BR> itself, which we don't yet represent visually. Maybe the selection should be before the '2'? Anyway, that would be a separate bug. If you backspace or delete, you'll remove the <BR> If you put your caret in front of the '2': "1 ^2" and hit backspace, you'll get "12" If you put your caret after the '1': "1^ 2" and hit delete, you'll also get "12" right? If so, the bug is fixed. If not, please show me a specific example of where it's broken.
okay still not fixed, tried your very last example...but then again it could be fixed in the 3/17 build...I'll wait till that and then re-verify this one.
I believe that's right, this code won't be in until tomorrow's build.
Status: RESOLVED → VERIFIED
verified in 3/17 build.
URL: any
You need to log in before you can comment on or make changes to this bug.