Hangas, I need this as a tracking bug/dependnecy for checking a fix for a crasher. Things are looking up only a few files to go: communicator\content\pref\pref-download.xul(101): <html:select communicator\content\search\find.xul(21): <html:select communicator\content\search\internet.xul(33): <html:select global\content\selectDialog.xul(23): <html:select messenger\content\SearchDialog.xul(37): <html:select messenger\content\am-main.xul(78): <html:select messenger\content\am-server.xul(79): <html:select messenger\content\addressbook\abNewCardDialog.xul(43): <html:select S:\mozilla\dist\WIN32_D.OBJ\bin\res\acct\am.xul(181): <html:select id="x"> S:\mozilla\dist\WIN32_D.OBJ\bin\res\acct\am2a.xul(159): <html:select id="x">

This one is huge, but it is also a subset of the effort to remove all html tags from our xul windows. The effort is moving much more slowly that we wanted. The engineers in question are across the project and working on nsbeta2 issues as fast as they can.

The reason I filed this bug, is because it blocks 36558 which we now have had 9 duplicate crasher bugs filed. It would really help us all out for me to get my checkin in. So I am not as worried about "all" the html controls, just the selects at this point.

I'm nominating this for dogfood, based on the fact that bug 37310 is [dogfood+] and a dup of bug 36558, which has a fix but depends on this bug. By the way, bug 36558 has 16 dupes by now, and several people have been spending their time on them: bug 36558 [FIX]browser crashes when loading deja search results bug 36608 Crash if I type http://www.justin.org into navbar. bug 36982 (topcrash)(talkback) bug 37261 [crash] winfiles.com crashes bug 37310 Crash in Bugsplat trying to 'build my own query' bug 37493 <SELECT> crashes in nsLineBox::DeleteLineList (e.g. composer or www.starwars.com) bug 36916 <SELECT> crashes composer/editor in nsLineBox::DeleteLineList bug 37821 <select> tag crashes editor bug 37619 Crashes during load, before page displayed, specific URL bug 38003 Mozilla crash when visiting www.newsnow.co.uk bug 37383 htmlparser/nsScanner.cpp bails on invalid(?) conversion of some text bug 38046 "viewer demos" (#16 Gfx Widgets) crashes mozilla bug 38220 mail crashes opening this message bug 38263 crash in nsLineBox::DeleteLineList bug 38328 CRASH while trying to visit http://www.starwars.com/ bug 38391 The Winfiles page always crashes Mozilla bug 38385 crash on NY Times

Removing dogfood kw since bug 36558 is fixed now.

jrgm, would this be appropriate fer ya?

[nsbeta2+]

The last two files remaining are: ./chrome/packages/core/communicator/content/pref/pref-download.xul which is owned by ben@netscape.com and ./chrome/packages/messenger/messenger/content/aw-server.xul is owned by alecf@netscape.com and is waiting for ben to rewrite the wizard state manager. Sending bug to Ben, who needs to fix the pref-download.xul find and rewrite the wizard state manager; at that point send the bug to alecf.

the wizard manager is not going to be re-written for beta2. sorry, no time. will fix the other instance.

Ben will just be doing the bookmarks search stuff. Who is doing the account wizard?

I am. Assign this to me when done with browser stuff

the select in the bookmarks search window has been removed. I'm passing this to alecf now to implement the Cheap Hack (tm) we discussed on IRC for nsbeta2. Here's what I suggest: a menulist with an associated <html:input type="hidden"/>, that gets its value set when the command handler on the menulist fires, is populated by the WSM on page load, and a load handler on the page that intialises the selected item of the menulist from the hidden form field. Ugly, but should work until I get time to rewrite the wizM after nsbeta2.

ok, I've removed our use of html:select as ben described. marking bug fixed!

Reopening. Looking at the commercial build for jul05 (the bits that will ship as PR2, not just dead cruft in the source trees), there are still a few places where <html:select> is in use. Most (all) look like they may be dead code, but they should still be either converted, or (most likely) removed from the build (bring out your dead). I've picked owners from cvs logs in lxr for these files. syd ./packages/core/communicator/content/pref/pref-IM_buddylist.xul andreww ./packages/aim/aim/content/findAFriend2_1.xul ./packages/aim/aim/content/findAFriend3_1.xul --- these are completely done in the html: namespace (select, script, div, fieldset, table, td, etc.) Are these dead code? ???? defaulting to ben ./packages/core/communicator/content/pref/pref-download.xul -- again, this is old style html: namespace heavy XUL. Is this dead code (or a placeholder for offline stuff that is not yet in place [and needs a rewrite])? rjc ./packages/core/communicator/content/search/internet.xul -- and one more, this is old style html: namespace heavy XUL. Not sure if this is still used. brade: ./packages/core/editor/content/EdImageMapHotSpot.xul --- html:select is commented out line 94-101; remove it alecf ./packages/messenger/messenger/content/am-main.xul --- html:select is commented out line 76-84; remove it I'm not sure if this still qualifies as nsbeta2+. ben? At any rate, assigning to syd for the first item on the list.

tedious bug, but html:foo must die!

Note: ./packages/core/communicator/content/search/internet.xul is no longer being used.

... so should it (internet.xul) be removed from the makefiles and manifest?

The files referred to me are not in use, and this stuff can be cleaned up post nsbeta2. This kind of cleanup and removal of cruft should not be nsbeta2+ unless it's causing crashes or visual defects. Sure it needs to be done, but that's what the next optimization phase is supposed to be, in my opinion. This stuff seems to be not very much at all related to the topic of this bug, except in an indirect way. I'd say a new bug "clean up unused crufty xul files" should be created and this bug closed. Remember what Phil said about finding ways to get rid of nsbeta2+ bugs... Again I agree this needs to be done, but it doesnt look like a nsbeta2+ candidate - whereas this original bug was.

Yes, I agree, cleaning up cruft can be done post-beta2. Note though that only the owners of some of these files can say whether this is dead code -- i.e., given 'remove all selects from UI', I couldn't tell whether this had been done. Ben confirmed that this was still a goal for beta2. Removing nsbeta2+, assuming that the other instances are also dead code.

Putting on [nsbeta2+] radar for beta2 fix.

Sorry, removing nsbeta2+

Putting on [nsbeta2-] radar. Not critical to beta2.

this probably needs to be owned by ben, or perhaps andreww

nav triage team: nsbeta3- Andrew, why don't you do what you suggested unless someone has objections, namely close this bug and open up a new one to get rid of old xul files.

done

Adding keyword to bugs with nsbeta3 triage value in status whiteboard so tracking queries will not be misled