Closed
Bug 38124
Opened 25 years ago
Closed 23 years ago
Duplicate access key "b" in context menu
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P3)
Core
DOM: UI Events & Focus Handling
Tracking
()
VERIFIED
FIXED
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Build ID: 2000050308
When right-clicking on a link, "Save Page As..." and "Save Link As..." both use
the access key "s" in the context menu. "Save Link As..." should probably use
the first "a" as the accelerator key, since that's what "Save Image As..." uses
when you right click on an image.
Furthermore, the context menu for a link uses the duplicate access key "L" for
both "Select All" and "Copy Link Location" I recommend changing the
accelerator for "Copy Link Location" since "L" has become an established key
for "Select All" throughout the program.
In seemingly all context menus, "Back" and "Bookmarks" use the same accelerator
key "B"
Sorry about putting these all into the same report, but I assume they can all
easily be fixed at once since they're all the same issue and all involve
context menu accelerators. Let me know, however, if you'd rather me split
these issues up.
Comment 1•25 years ago
|
||
nothing to do with xpmenus.
Assignee: pinkerton → ben
Component: XP Toolkit/Widgets: Menus → XPApps
Putting on [nsbeta2-] radar. Not critical to beta2.
Whiteboard: [nsbeta2-]
Assignee | ||
Comment 4•25 years ago
|
||
I'll take this one. Are there any localizability problems I have to watch out
for, or are the standard 26 a-z letters all valid access keys? Also, is there
a spec for what commands should use which letters?
Assignee: ben → BlakeR1234
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•25 years ago
|
||
german, any spec or good rules to follow when decided access keys? what's the
order of precedence (i.e.: (1) Backwards compability with 4x (2) Platform
Standard (3) First non-used consonant (4) first non-used vowel) ? I see a
bunch of duplicate access keys scattered throughout and I'm gonna try to fix
all of them with one patch. Also, any localibility issues to watch out for (I
would assume no)?
Assignee | ||
Comment 6•24 years ago
|
||
Matthew, can you answer some of my previous questions?
Comment 7•24 years ago
|
||
Blake: As for your first question, safe mnemonic keys are all 26 letters and all
10 digits -- see bug 36048.
As for your second question, to arrange my criteria in bug 41515 into some sort
of order of importance ...
(1) consistency with the same menu item, if the menu item text changes during use
of the app (rare)
(2) consistency with other menus/controls in the same app
- consistency of context menus with main menus
- consistency of {component x} menus with {component y} menus (e.g. if a
particular item does something rather destructive in Messenger, you
probably shouldn't use the same access key in the same menu for something
trivial in Navigator)
- consistency of menus with equivalent dialogs
(3) obviousness
- the letter the most important word in the item starts or ends with
- `most important word' can be a minor word, if that minor word is what
differentiates the menu item from another one (e.g. `As' in `Save As')
(4) consistency with other contemporary apps
- especially competing ones
(5) consistency with previous versions of Mozilla
(6) speed
- with particular regard to the QWERTY keyboard
- not an issue for context menus, since they usually aren't nested
(7) localizability, to minimize relearning when I start using a
different-language version
- e.g. `n' is usually a good choice for a negative menu item.
As you've probably realized by now, it's not a good idea to give `Save Link As'
and `Save Image As' the same mnemonic, since an image which acts as a link will
have both items. ... [tries it] Hmm, ok, it doesn't. But it should.
I'm not going to give specific suggestions for these mnemonics, because:
* with the exception of the duplicate `B' usage, your specific complaints seem to
have been fixed already (albeit in a somewhat odd fashion);
* I'm Mac-bound, so I can't see what the corresponding mnemonics in the main
menus are;
* I'm not going to recommend anything which would imply that I agree that `Save
Page As ...' should be in the context menu (it shouldn't be); and
* I'd have to work around the sill- ... um,
rather-inconsistent-with-the-rest-of-the-world, use of `L' (rather than `A')
for `Select All', and I'd be unable to do that with a straight face.
Assignee | ||
Comment 8•24 years ago
|
||
Thanks for the help, Matthew. Will look at all this when I return...
Updated•24 years ago
|
Component: XP Apps → Keyboard Navigation
Assignee | ||
Updated•24 years ago
|
Priority: P3 → P2
Target Milestone: M20 → M19
Comment 9•24 years ago
|
||
clarifying summary.
Summary: Duplicate accelerator keys "s", "b", and "l" on context menu → Duplicate access keys "s", "b", and "l" on context menu
Assignee | ||
Updated•24 years ago
|
Priority: P2 → P3
Target Milestone: M19 → mozilla1.0
Assignee | ||
Comment 10•24 years ago
|
||
timeless, wanna take this one?
Comment 11•24 years ago
|
||
I have a simple solution for this. But I'll need to write up a proposal. And
then i'll have to commit it while mpt is unavailable. MPT: Would you consider
it?
Assignee | ||
Comment 12•24 years ago
|
||
cool. reassigning to you.
Assignee: blakeross → timeless
Status: ASSIGNED → NEW
Comment 13•24 years ago
|
||
I'll happily consider any proposal ... But if the question is hierarchical
context menus, then the answer is no. Again.
Comment 14•24 years ago
|
||
Looks like everything is fixed except the dup'd B's: bookmarks and back.
Comment 15•24 years ago
|
||
summary
Summary: Duplicate access keys "s", "b", and "l" on context menu → Duplicate access key "b" in context menu
Comment 16•23 years ago
|
||
nominating for 0.9.4 for reconsideration.
Comment 17•23 years ago
|
||
try again for moz0.9.5?
adding dependency, to make it easier for me to find this wrt context menu issues.
Depends on: 75338
Keywords: mozilla0.9.4 → mozilla0.9.5
Updated•23 years ago
|
Keywords: mozilla0.9.5
Assignee | ||
Comment 19•23 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 20•23 years ago
|
||
vrfy'd fixed on win2k and linux rh7.2, 2002.04.09 comm bits. no longer see
duplicate 'b' in content context menu.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Component: Keyboard: Navigation → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•