2000050715 Click Customize in the Search Sidebar. Click Rename, enter something, Click Ok. Expected Result: Category listbox should update selected category. Actual result: Not updated Clicking the Category dropdown will show that the category was renamed.

over to ben...

Putting on [nsbeta2-] radar. Not critical to beta2. If you can get in by 5/16 great....otherwise fix for nsbeta3.

Move to M20.

um, out of curiosity, why is this ben's bug?

Search sidebar currently doesn't have a customise button. So: It seems unclear to me whether this bug requires either of a "developer" or "user" release note for Netscape 6 RTM. If anyone feels it does, can they please draft one and then nominate with the relnote-user or relnote-devel strings in the Status Whiteboard. Thanks :-) Gerv

It's now called Edit Categories in the Search within categories drop down. cc mpt, because i want to know which bug introduced that 'feature' and i want to know if he blessed it. I just crashed trying to follow my steps [tip ~9pm edt today solaris8intel]. I'll have a stack trace shortly. Once this bug loses its crasher status if it is not fixed it would be relnote-user. Since we're crashing i'll hope we fix this correctly for rtm. I'm nomimating rtm because users will notice this.

#0 0xdf86d9fe in js_NewContext (rt=0x81068b0, stackChunkSize=8192) at jscntxt.c:91 #1 0xdf861d73 in JS_NewContext (rt=0x81068b0, stackChunkSize=8192) at jsapi.c:826 #2 0xde50a138 in nsJSContext::nsJSContext (this=0x8a22058, aRuntime=0x81068b0) at nsJSEnvironment.cpp:312 #3 0xde50e3ba in nsJSEnvironment::GetNewContext (this=0x8173fa8) at nsJSEnvironment.cpp:1495 #4 0xde50e42c in NS_CreateScriptContext (aGlobal=0x8833ea0, aContext=0x8a8b858) at nsJSEnvironment.cpp:1507 #5 0xdd69ac96 in nsDocShell::EnsureScriptEnvironment (this=0x8a8b7a8) at nsDocShell.cpp:4394 #6 0xdd69c072 in nsWebShell::GetInterface (this=0x8a8b7a8, aIID=@0xdf376158, aInstancePtr=0x804458c) at nsWebShell.cpp:320 #7 0xdf9e0055 in nsGetInterface::operator() (this=0x80445fc, aIID=@0xdf376158, aInstancePtr=0x804458c) at nsIInterfaceRequestor.cpp:37 #8 0xdf344247 in ?? () at ../../dist/include/nsCharTraits.h:91 from /mnt/extra/timeless/mozilla/dist/bin/components/libxpinstall.so #9 0xde7539d5 in ?? () at ../../../dist/include/nsAWritableString.h:838 from /mnt/extra/timeless/mozilla/dist/bin/./libjsdom.so #10 0xde539716 in GlobalWindowImpl::ReadyOpenedDocShellItem (this=0x87fb568, aDocShellItem=0x8a8b7ac, aDOMWindow=0x8044bb0) at nsGlobalWindow.cpp:3448 #11 0xde536e2a in GlobalWindowImpl::OpenInternal (this=0x87fb568, cx=0x8848238, argv=0x8b19b78, argc=4, aDialog=1, aReturn=0x8044bb0) at nsGlobalWindow.cpp:3019 #12 0xde530cec in GlobalWindowImpl::OpenDialog (this=0x87fb568, cx=0x8848238, argv=0x8b19b78, argc=4, aReturn=0x8044bb0) at nsGlobalWindow.cpp:2022 #13 0xdf158ad0 in nsCommonDialogs::DoDialog (this=0x8646468, inParent=0x87fb56c, ioParamBlock=0x88bccc0, inChromeURL=0xdf1bdca0 "chrome://global/content/commonDialog.xul") at nsCommonDialogs.cpp:453 #14 0xdf157dd3 in nsCommonDialogs::Prompt (this=0x8646468, inParent=0x87fb56c, inWindowTitle=0x8b41e88, inMsg=0x859a540, inDefaultText=0x8aa8678, result=0x8044e6c, _retval=0x8044e7c) at nsCommonDialogs.cpp:302 #15 0xdf9f4371 in XPTC_InvokeByIndex (that=0x8646468, methodIndex=7, paramCount=6, params=0x8044e2c) at xptcinvoke_unixish_x86.cpp:134 #16 0xddf182a0 in nsXPCWrappedNativeClass::CallWrappedMethod (this=0x894ea60, cx=0x8848238, wrapper=0x894ebe8, desc=0x894eafc, callMode=CALL_METHOD, argc=5, argv=0x8b19b5c, vp=0x8044fd4) at xpcwrappednativeclass.cpp:913 #17 0xddf1a7b7 in WrappedNative_CallMethod (cx=0x8848238, obj=0x884e320, argc=5, argv=0x8b19b5c, vp=0x8044fd4) at xpcwrappednativejsops.cpp:228 #18 0xdf88edd2 in js_Invoke (cx=0x8848238, argc=5, flags=0) at jsinterp.c:790 #19 0xdf89bae6 in js_Interpret (cx=0x8848238, result=0x80459a0) at jsinterp.c:2589 #20 0xdf88ee54 in js_Invoke (cx=0x8848238, argc=1, flags=2) at jsinterp.c:807 #21 0xdf88f18b in js_InternalInvoke (cx=0x8848238, obj=0x884e728, fval=139349080, flags=0, argc=1, argv=0x8045cc4, rval=0x8045b68) at jsinterp.c:879 #22 0xdf866ea1 in JS_CallFunctionValue (cx=0x8848238, obj=0x884e728, fval=139349080, argc=1, argv=0x8045cc4, rval=0x8045b68) at jsapi.c:3193 #23 0xde50ca00 in nsJSContext::CallEventHandler (this=0x88481f0, aTarget=0x884e728, aHandler=0x84e4c58, argc=1, argv=0x8045cc4, aBoolResult=0x8045c14, aReverseReturnResult=0) at nsJSEnvironment.cpp:906 #24 0xde5721e7 in nsJSEventListener::HandleEvent (this=0x8952c78, aEvent=0x870cbd4) at nsJSEventListener.cpp:154 #25 0xdbee9cbf in nsEventListenerManager::HandleEventSubType (this=0x89537e8, aListenerStruct=0x8952438, aDOMEvent=0x870cbd4, aCurrentTarget=0x8953798, aSubType=8, aPhaseFlags=7) at nsEventListenerManager.cpp:788 #26 0xdbeeccd4 in nsEventListenerManager::HandleEvent (this=0x89537e8, aPresContext=0x87e9e80, aEvent=0x8046918, aDOMEvent=0x804685c, aCurrentTarget=0x8953798, aFlags=7, aEventStatus=0x804695c) at nsEventListenerManager.cpp:1670 #27 0xddceb732 in nsXULElement::HandleDOMEvent (this=0x8953790, aPresContext=0x87e9e80, aEvent=0x8046918, aDOMEvent=0x804685c, aFlags=1, aEventStatus=0x804695c) at nsXULElement.cpp:3304 #28 0xdbf750cb in PresShell::HandleDOMEventWithTarget (this=0x87eca58, aTargetContent=0x8953790, aEvent=0x8046918, aStatus=0x804695c) at nsPresShell.cpp:4963 #29 0xdc215db3 in nsButtonBoxFrame::MouseClicked (this=0x895d7a8, aPresContext=0x87e9e80, aEvent=0x8046bc4) at nsButtonBoxFrame.cpp:136 #30 0xdc215b09 in nsButtonBoxFrame::HandleEvent (this=0x895d7a8, aPresContext=0x87e9e80, aEvent=0x8046bc4, aEventStatus=0x8047218) at nsButtonBoxFrame.cpp:95 #31 0xdbf74ee4 in PresShell::HandleEventInternal (this=0x87eca58, aEvent=0x8046bc4, aView=0x0, aFlags=1, aStatus=0x8047218) at nsPresShell.cpp:4931 #32 0xdbf74bf2 in PresShell::HandleEventWithTarget (this=0x87eca58, aEvent=0x8046bc4, aFrame=0x895d7a8, aContent=0x8953790, aFlags=1, aStatus=0x8047218) at nsPresShell.cpp:4897

After staring blankly at the sidebar search panel and trying to imagine into existence a Customize Dialog I finally found this Search|My Sidebar Search Tab menu item (in the main menubar) that let me set my search to Advanced (it was set to basic). After this discovery I was able to run through the steps to reproduce this bug and can confirm that it is indeed a bug. The name in the Edit Catagories is not updated until you close it and reopen. I did not experience any crash with win32, mac or linux trunk mozilla builds 102404/08

I don't see the crash either. timeless, can anyone besides you repro the crash? Claudius, how about you? Although it's disappointing the category name isn't updating, I wouldn't hold NS6 for it. Minus. BTW, please clear the minus if we can get the crash to happen consistently.

Timeless, I know nothing -- I find Mozilla's search functions to be unusably confusing/annoying, so I try not to notice them. :-/ Right. When I rename a category, the old name remains visible in the popup menu button, but the new name is shown in the menu itself when I open it. Selecting the category again doesn't update the button, but selecting another category and then the renamed category *does* update the button. So it looks as though when a menu item is renamed in a popup menu, a check isn't being made to see if the renamed item also happens to be the selected item -- if it is, the menu button should be redrawn. That means this is an XPToolkit/Widgets: Menus bug. Reassigning. My work here is done.

resummarizing. if rtm-, this cannot be mozilla0.6

Reselecting the current item doesn't work either, because the menulist optimizes it away :-( Perhaps you want an extra method to refresh the selected item?

new owner

Please reopen with Steps To Reproduce if this bug is still relevant.