Closed
Bug 38745
Opened 25 years ago
Closed 25 years ago
stop changing the file names for the mac build
Categories
(SeaMonkey :: Build Config, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M16
People
(Reporter: endico, Assigned: jj.enser)
Details
is there some reason the file name for the daily builds
changes all the time? If you could pick a file name and stay
with it, that would help mac testing immensely because then
links to the mac daily builds wouldn't break and people could
download the software on a regular basis.
There are two problems.
1) you put the milestone number in the file name. Since the
milestone changes from time to time the link is guaranteed
to be broken if i don't happen to think of updating the link
when the tree branches.
2) You change the rest of the file name too! The mac builds
used to be MozMacInstaller* but now they're MozillaInstaller*.
Assignee | ||
Comment 1•25 years ago
|
||
Let me explain:
Yes, we had a good reason to change the file names for the mac daily deliveries.
Installer file names had to be changed, (see bug #33595) and to have a coherent
automation, encoded file names changed as well. they are now 'MozillaInstaller-
M16.sea.bin' and 'mozilla-mac-M16.sea.bin' for the self-extracting archive. We
should stick with these file names unless another related bug appears (or a
marketing request, or whatever).
I don't have change file names for the fun of it, but usually to improve
something that might not be obvious at first sight. This explains problem #2 you
mention above.
regarding "problem" #1, the milestone is part of the filename in order to be able
to differienciate the different builds. I think other platform should fo the same
;-). Now, how difficult is it to updated the links once per milestone?
I understand that I should have informed you about this change in the file naming
convention, but didn't. My mistake. If other changes occur in the future, I will
make sure you know about them.
marking fixed.
Status: NEW → RESOLVED
Closed: 25 years ago
OS: Windows NT → Mac System 8.6
Hardware: PC → Macintosh
Resolution: --- → FIXED
Comment 2•25 years ago
|
||
jj... is there anything i can do to convince you that the filenames don't need
the milestone number in them in the regular builds?
The directories on ftp.mozilla.org describe the milestone well enough, i think,
and latest should always be the last build, even if it does come from a branch.
We can maybe change the behaviour of the delivery for milestone candidate builds
to not deliver to latest, or deliver a different filename when there is overlap.
What do you say?
Reporter | ||
Comment 3•25 years ago
|
||
Actually its a big headache updating file names all over the doc tree when
the milestone changes. I don't want this extra busy work every milestone. If
you remove the number from the file name the process will Just Work without any
human intervention just like it does for other platforms.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•25 years ago
|
||
ok, I'm ready to make the necessary code changes to BuildCentral to remove the
milestone suffix from the installer filename. Proposed changes are:
- installer name before beeing encoded will be changed to 'Mozilla Installer'
- the corresponding encoded file (ftp) will be named 'MozillaInstaller.sea.bin'
Things that won't change:
- the directory name will continue to end include the milestone, i.e.
'2000-05-24-20-M16'
- the self-extracting archive file name will remain 'mozilla-mac-m16.sea.bin'. To
change this, simply modify the <public_folder_name> value in the BuildCentral
settings file. No code change is necessary.
- Netscape 6 file names don't change (Netscape6-mac and Netscape6Installer)
Let me know if this proposal is ok with you and I'll rev BuildCentral
accordingly.
Status: REOPENED → ASSIGNED
Reporter | ||
Comment 5•25 years ago
|
||
That looks fine to me. Although it would be nice if the file name
had the word "mac" in it somewhere for the benefit of executive
types looking at server logs. This is minor though. I'll be happy
with just what you've done already. Thanks!
Assignee | ||
Comment 6•25 years ago
|
||
Added 'Mac' to the _beginning_ of the file name, using a 'patch' in order to
preserve the automation in place which defines the bits name based on the top
folder name before compression & encoding. (i.e. "Mozilla Installer" becomes
'MozillaInstaller.sea.bin', 'Netscape 6 Installer' becomes
'Netscape6Installer.sea.bin').
now we will have 'Mozilla Installer' -> 'MacMozillaInstaller.sea.bin'
and 'Netscape 6 Installer' -> 'MacNetscape6Installer.sea.bin'
Leaf/Jon, let me know if this needs to be in for M16, I have the patches ready to
be applied to Bassman at any time.
Comment 7•25 years ago
|
||
sounds great, let's check that bad boy in.
Assignee | ||
Comment 8•25 years ago
|
||
fixed.
I updated BuildCentral to reflect the suggested changes. (together with the
changes for the MRJ plugin)
the notification email should show the new names in the urls.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Comment 9•25 years ago
|
||
sweet. thanks, jj.
I cleared out the old filenames from the "current" directory and on the mozilla
ftp server as well.
verified.
Status: RESOLVED → VERIFIED
Target Milestone: --- → M16
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•