Closed Bug 38764 Opened 25 years ago Closed 25 years ago

Background image on an inline element is repeated if element is displayed in multiple frames

Categories

(Core :: Layout, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: cmanske, Assigned: attinasi)

References

Details

Attachments

(1 file)

Start Composer. Click on Bold button and type some bold text. Press Enter to break to a new line. Type some more. Click on "Show All Tags" button at bottom of window to activate that mode. This CSS is used to show a background image behind the text in the <b> element. b { min-height: 35px; margin-left: 2px; margin-top: 2px; padding-left: 16px; background: url(chrome://editor/content/images/tag-b.gif) no-repeat; background-position: top left; } Note that the image is repeated on the second line even though the rule is "norepeat" I'll try to construct a simpler test example for viewer.
Adding blocks
Blocks: 28498
Severity: normal → blocker
Attached file Testcase for use in viewer (deleted) —
This is a layout problem. There is a continuing line and it is not respecting the no-repeat when it draws the background on the continued line. I'll take a stab at fixing this. Setting milestone to match the blocked bug.
Status: NEW → ASSIGNED
Target Milestone: --- → M16
OK - I have a fix for this that is actually in the CSSRendering code. PaintBackground now checks to see if the frame is a continuation, and if so, it makes sure the repeat-y value is set before painting in the background. Checking in... (nsCSSRendering.cpp)
Fix checked in. (nsCSSRendering.cpp)
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Thanks. "you're the man".
Fixed in the May 23 build.
Status: RESOLVED → VERIFIED
Oops. I mean the May 22nd builds (Mac, Win 98, Linux).
Note that my patch to bug 14777 will back out this fix, though the problem as originally described will not regress. (I've tested editor's all tags mode with my proposed patch to verify this)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: